-
Notifications
You must be signed in to change notification settings - Fork 458
Publish warning message changes #4357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Hi @aishwaryabh , I’ve created a new pull request as the previous one had multiple conflicts with the main branch. Could you please review the new PR when you get a moment? I’ll go ahead and close the old one. Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Before reviewing/asking additional questions, I wanted to check if the logic here was influenced by the existing implementation in other tools (e.g., Azure CLI). Wast that the case? Does the logic there align with how the target stack version resolution is done?
One minor comment in the meantime; please update the formatting logic for anything that is being displayed to the user to use the appropriate culture. Things like date formatting, for example, should be done using that user's culture information.
Hey Fabio, Regarding the logic: It is based on the existing implementation already present for the .NET isolated publish flow in Azure Functions Core Tools. That flow uses the Azure Functions Stacks API to determine the major .NET version, retrieve corresponding runtime settings, and evaluate deprecation/EOL dates before publishing. I followed the same pattern and extended it to other worker runtimes (e.g., Python, Node.js, PowerShell, Java) using the same stack API-based approach. This was not influenced by the Azure CLI logic specifically. For culture-specific formatting, I’ll update all user-facing date formatting to respect |
Hey @fabiocav , @aishwaryabh , kindly review the PR at your convenience and let me know if any further modifications are needed. |
Hi @umangsriv - can you update the tests on this PR to be in the new test project? (unit tests in Unit and e2e tests in E2E project) |
Hi @liliankasem , I’ve added the tests in this PR to the new Unit Test Project, please review them when you have a moment. |
Hi @liliankasem @umangsriv could you please share an update on this PR? |
Publish warning message for other (NodeJS, Python, Java, etc.) worker runtime
resolves #4241
Pull request checklist