Creating Azure.Functions.Cli.Abstractions needed for new testing framework#4362
Creating Azure.Functions.Cli.Abstractions needed for new testing framework#4362aishwaryabh merged 12 commits intomainfrom
Azure.Functions.Cli.Abstractions needed for new testing framework#4362Conversation
Can you commit the original in first and either a) in a new PR make the change youre talking about here or b) make that change in a new commit so that we can review what changed from the original file |
|
I think we should create folders to organize these files i.e.
The rest can stay at root |
Azure.Functions.Cli.Abstractions needed for new testing frameworkAzure.Functions.Cli.Abstractions needed for new testing framework
yes! so |
8983187 to
055afa2
Compare
53ef2e4 to
cbc1513
Compare
694a388 to
bb13151
Compare

Issue describing the changes in this PR
resolves #4327
This PR is the first part of a series of PRs to set up a new testing framework for the Azure Functions CLI. This is the larger PR, which contains all the changes for the testing framework and the updated func start E2E test, if you would like to take a look at how it all fits in! I just decided to split it up since it would be easier to review and get feedback this way.
The
Azure.Functions.Cli.Abstractions.csprojcontains the abstractions that are copied from the .NET SDK. The only difference isCommand.csin how theProcessStartedHandleris initialized and called, since we have to account for the process being async. Once the host starts, we use theProcessStartedHandlerto get direct access to the process that has been created and the logs that are emitted from that specific process as well, which is why we must await the host to be ready first before checking any logs.Pull request checklist