Update versioning logic & move TelemetryInstrumentationKey to its own Constants file#4469
Merged
liliankasem merged 2 commits intofeature/build-projectfrom Jun 10, 2025
Merged
Conversation
jviau
approved these changes
Jun 9, 2025
jviau
approved these changes
Jun 10, 2025
aishwaryabh
approved these changes
Jun 10, 2025
liliankasem
added a commit
that referenced
this pull request
Jun 27, 2025
… Constants file (#4469) * Update versioning logic & move TelemetryInstrumentationKey * Use attribute approach for setting TelemetryInstrumentationKey
liliankasem
added a commit
that referenced
this pull request
Jul 2, 2025
… Constants file (#4469) * Update versioning logic & move TelemetryInstrumentationKey * Use attribute approach for setting TelemetryInstrumentationKey
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces an AssembleyExtensions.cs file to help us get the CLI version. The
InformationalVersionlooks like this:4.0.10000-dev+67bd99a8ce2ec3cf833f25c039f60222caf44573 (64-bit)And the
GetCliVersionmethod allows us extract the first part if it i.e.4.0.10000-dev(Note: on release -dev or -ci will not be part of the CLI version)
Second, we convert constants to a partial class so that we can override the value of TelemetryInstrumentationKey as part of the build process.