Implement msbuild targets to replace Build.csproj#4498
Merged
Conversation
… Constants file (#4469) * Update versioning logic & move TelemetryInstrumentationKey * Use attribute approach for setting TelemetryInstrumentationKey
* Fix unit tests * Add unit test proj to sln & tidy up props
62373c5 to
7fc1a46
Compare
5 tasks
satvu
approved these changes
Jul 3, 2025
surgupta-msft
approved these changes
Jul 3, 2025
aishwaryabh
approved these changes
Jul 7, 2025
fabiocav
approved these changes
Jul 8, 2025
| <LangVersion>latest</LangVersion> | ||
| <ImplicitUsings>enable</ImplicitUsings> | ||
| <Nullable>enable</Nullable> | ||
| <GenerateRuntimeConfigDevFile>true</GenerateRuntimeConfigDevFile><!-- https://github.com/dotnet/runtime/issues/54684 --> |
Member
There was a problem hiding this comment.
This is referencing an issue that has been closed as resolved (and opened in the context of .NET 6). Still applicable?
jviau
approved these changes
Jul 8, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR replaces the old Build.csproj approach with MSBuild props and targets, refactors repo structure, and updates CI pipelines to run tests and RID builds in parallel.
- Introduce
Directory.Build.props/targetsand related MSBuild files undereng/build/ - Add a standalone
GoZipToolproject and integrate its build into the CLI MSBuild - Revamp CI YAML: use
$(SrcRoot)/$(EngBuildRoot)paths, parallelize builds/tests, and update artifact signing
Reviewed Changes
Copilot reviewed 91 out of 125 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| Directory.Build.props / Directory.Build.targets | Import Engineering.props/targets and drop custom Cli.Build.targets |
| src/GoZipTool/GoZipTool.csproj | New MSBuild NoTargets project for building GoZip per RID |
| src/Cli/func/*.csproj and related props/targets | Update project references, enable C#12 array init, add version props/targets |
| src/Cli/func/Common/Constants.* | Move telemetry key to build-only file, switch to extension methods |
| eng/build/* | New MSBuild targets for templates, zipping, versioning, release |
| eng/scripts | Script path updates, parameter renames, improved MSI and SHA logic |
| eng/ci/templates/* | YAML refactor: path variables, parallel jobs, templated stages |
| docker/* | Update Dockerfile and compose for new structure |
Comments suppressed due to low confidence (2)
eng/ci/templates/steps/install-tools.yml:15
- The
NuGetToolInstaller@1task has an emptyversionSpecinput. Specify a version (e.g.,'latest') or remove the setting to avoid failures during tool installation.
versionSpec:
docker/Dockerfile:12
- The Dockerfile no longer copies and runs
download-templates.ps1, which may prevent the templates.json from being generated in the container. Ensure MSBuild'sDownloadAndExtractTemplatesJsontarget runs successfully in this image or reintroduce the script step.
COPY eng/ eng/
e200183 to
7fc1a46
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue describing the changes in this PR
resolves #4303
Pull request checklist
Additional Information
All PRs have been previously reviewed and approved, this is the big merge of this feature into main.
Implement GoZipTool as NoTargets csproj
Move MSI resources to eng/res folder
Move publish scripts to tools/publish-tools
Update versioning logic & move TelemetryInstrumentationKey to its own…
Impement build props and targets
Update scripts
Misc updates & fixes to documentation, docker, .targets, and tests
Implement new CI pipelines that will build, sign, test & publish the …
Clean up CI files & fix version regex
Fix unit test project
Update host and consolidation CI pipelines