Fix keda templates & namespace config#4558
Merged
liliankasem merged 6 commits intomainfrom Aug 4, 2025
Merged
Conversation
jviau
approved these changes
Aug 1, 2025
surgupta-msft
approved these changes
Aug 1, 2025
aishwaryabh
approved these changes
Aug 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue describing the changes in this PR
resolves #1883
Pull request checklist
release_notes.mdAdditional information
When running
func kubernetes install --namespace mynsfor V2, the namespace value is ignored the templates do not haveKEDA_NAMESPACEstring to replace. I've updated the V2 templates to replace the default namespaces withKEDA_NAMESPACEso that we do actually take the namespace into account. Instead we now programmatically set the default value is the namespace is not provided.I also found that when a namespace is not provided, we still return "true" on
CreateNamespacewithout actually checking if a default namespace exists. This results in the action failing if we do not provide a namespace and the "default" namespace does not exist. Fixed this by checking for the config namespace, and if not set, we provide a default namespace value instead of leaving namespace as null.