Replace IMemoryMappedFileAccessor with null implementation #4573
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liliankasem
commented
Aug 5, 2025
| @@ -84,6 +86,9 @@ public IServiceProvider ConfigureServices(IServiceCollection services) | |||
|
|
|||
| services.AddWebJobsScriptHost(_builderContext.Configuration); | |||
|
|
|||
| // Replace the default MemoryMappedFileAccessor with a null implementation | |||
| services.Replace(ServiceDescriptor.Singleton<IMemoryMappedFileAccessor, NullMemoryMappedFileAccessor>()); | |||
There was a problem hiding this comment.
@fabiocav draft here; still need to consider all the potential impact of disabling this - let me know what you think
There was a problem hiding this comment.
But I think we still want to allow users to test this feature right? So maybe disable by default and add a flag to bring this back in. Or we just don't make a change here and fix it on the host side?
| public override void Delete(string mapName, MemoryMappedFile mmf) | ||
| { | ||
| Logger.LogDebug("NullMemoryMappedFileAccessor: Delete called for {MapName} - no action taken", mapName); | ||
| mmf?.Dispose(); |
There was a problem hiding this comment.
Should we care about mmf not being null or not already disposed?
| /// A null implementation of MemoryMappedFileAccessor that disables shared memory functionality. | ||
| /// This can be used for testing or in environments where shared memory is not supported or desired. | ||
| /// </summary> | ||
| public class NullMemoryMappedFileAccessor : MemoryMappedFileAccessor |
There was a problem hiding this comment.
Seal it to prevent unintended extension.
| Logger.LogDebug("Using NullMemoryMappedFileAccessor - shared memory data transfer is disabled"); | ||
| } | ||
|
|
||
| public override bool TryCreate(string mapName, long size, out MemoryMappedFile mmf) |
There was a problem hiding this comment.
Adding a comment can help - "/// Always returns false; no shared memory is created. ///"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue describing the changes in this PR
resolves #issue_for_this_pr
Pull request checklist
release_notes.mdAdditional information
Additional PR information