Move core-tools setup to separate yml. Use dotnet run. #3289
+98
−66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the E2E test setup to make tests runnable locally without script dependencies by: 1) Switching from direct func CLI invocation to dotnet run for starting function apps, and 2) Moving Azure Functions Core Tools installation into a separate reusable YAML template.
Changes:
- Extracted Core Tools installation logic into a dedicated template file (
install-core-tools.yml) - Modified test fixtures to use
dotnet run --no-buildinstead of directly invoking the func CLI - Simplified using statements in TestUtility.cs to use C# 8+ using declarations
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| test/Sdk.E2ETests/TestUtility.cs | Refactored nested using statements to modern using declarations (style improvement) |
| test/E2ETests/E2ETests/Fixtures/FixtureHelpers.cs | Changed process execution from func CLI to dotnet run with updated argument handling |
| test/E2ETests/E2EApps/E2EAspNetCoreApp/E2EAspNetCoreApp.csproj | Added blank line before closing tag (formatting) |
| eng/ci/templates/steps/setup-e2e-tests.yml | Integrated new install-core-tools template and passed SkipCoreTools flag |
| eng/ci/templates/steps/install-core-tools.yml | New template for downloading and installing Azure Functions Core Tools |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
jviau
force-pushed
the
u/jviau/setup-core-tools
branch
from
d25ca90 to
db851c6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue describing the changes in this PR
resolves #issue_for_this_pr
Pull request checklist
release_notes.mdAdditional information
This PR is part of an effort to make e2e tests runnable locally with no script setup required. This PR specifically does two things:
dotnet runfor running the function apps, which will find func on the path.PATHon install.The motivation for this PR is to reduce setup needed locally to run e2e tests, which was complicating local verification of different CI changes. This lets local runs of e2e tests just leverage your installed func cli, instead of needing it installed to a specific folder.