Changed warning logged when distributed tracing is enabled but APPINS… #3188
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…IGHTS_INSTRUMENTATIONKEY isn't set to an information message
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the warning logged when distributed tracing is enabled but Application Insights (AI) is not to an information message. Distributed tracing is supported in AI, but AI is not required for this to work. Showing this as a warning is wrong IMO since you can use other logging destinations than AI and still have distributed tracing working as expected.
I have updated the test, but I don't believe any documentation changes are needed. The changes do not need to be backported unless desired.