-
Notifications
You must be signed in to change notification settings - Fork 284
Add .NET Isolated Durable Entities sample #3228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
|
@bachuv I just merged the latest from dev back into this branch. Can you please update this new sample to be consistent with the changes I made to the other samples yesterday - this will include adding your sample project to the Samples.sln in /samples directory and ensuring that the sample project compiles using the new CPM settings. Thanks |
| <PackageReference Include="Microsoft.ApplicationInsights.WorkerService" VersionOverride="2.23.0" /> | ||
| <PackageReference Include="Microsoft.Azure.Functions.Worker" VersionOverride="2.1.0" /> | ||
| <PackageReference Include="Microsoft.Azure.Functions.Worker.ApplicationInsights" VersionOverride="2.0.0" /> | ||
| <PackageReference Include="Microsoft.Azure.Functions.Worker.Extensions.DurableTask" VersionOverride="1.6.1" /> | ||
| <PackageReference Include="Microsoft.Azure.Functions.Worker.Extensions.Http" VersionOverride="3.3.0" /> | ||
| <PackageReference Include="Microsoft.Azure.Functions.Worker.Extensions.Http.AspNetCore" VersionOverride="2.0.2" /> | ||
| <PackageReference Include="Microsoft.Azure.Functions.Worker.Sdk" VersionOverride="2.0.5" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If possible, can we remove VersionOverride here and just update the relevant versions in /samples/Packages.Directory.props? The Samples.sln should ensure that all .NET samples compile with the changes. Hopefully everything just works, but If this breaks the other tests, VersionOverride should be fine for now
|
@bachuv - Thanks for updating the entities sample! I was able to run the sample locally. Noticed a few things -
For example, I added 3 chrips to Alice and expecting the GET request to return them, but it returned nothing
|
This PR adds a .NET Isolated Durable Entities sample which uses Durable Functions v3. The current samples use Durable Functions v2.
Pull request checklist
pending_docs.mdrelease_notes.md/src/Worker.Extensions.DurableTask/AssemblyInfo.csdevandmainbranches and will not be merged into thev2.xbranch.