-
Notifications
You must be signed in to change notification settings - Fork 284
Add API to get orchestration history in .NET Isolated #3268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
sophiatev
wants to merge
3
commits into
dev
Choose a base branch
from
stevosyan/add-orchestration-history-api-isolated
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
78 changes: 78 additions & 0 deletions
78
src/WebJobs.Extensions.DurableTask/HistoryEventJsonConverter.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,78 @@ | ||
| // Copyright (c) .NET Foundation. All rights reserved. | ||
| // Licensed under the MIT License. See LICENSE in the project root for license information. | ||
|
|
||
| #nullable enable | ||
| using System; | ||
| using DurableTask.Core.History; | ||
| using Newtonsoft.Json; | ||
| using Newtonsoft.Json.Linq; | ||
|
|
||
| namespace Microsoft.Azure.WebJobs.Extensions.DurableTask | ||
| { | ||
| /// <summary> | ||
| /// Provides custom JSON deserialization for <see cref="HistoryEvent"> objects, mapping each event type to its corresponding | ||
| /// concrete class. This converter enables polymorphic deserialization of history events based on the EventType | ||
| /// property in the JSON payload. | ||
| /// </summary> | ||
| /// <remarks> | ||
| /// This converter only supports reading (deserialization) and does not support writing (serialization) of <see cref="HistoryEvent"> objects. | ||
| /// When deserializing, the EventType property in the JSON must be present and correspond to a known <see cref="EventType">; | ||
| /// otherwise, a <see cref="JsonSerializationException"/> (for a missing EventType property) or <see cref="NotSupportedException"/> | ||
| /// (for an unknown EventType) will be thrown. | ||
| /// </remarks> | ||
| public class HistoryEventJsonConverter : JsonConverter | ||
| { | ||
| /// <inheritdoc/> | ||
| public override bool CanWrite => false; | ||
|
|
||
| /// <inheritdoc/> | ||
| public override bool CanConvert(Type objectType) | ||
| { | ||
| return objectType == typeof(HistoryEvent); | ||
| } | ||
|
|
||
| /// <inheritdoc/> | ||
| /// <throws><see cref="JsonSerializationException"/> If the EventType property is missing in the JSON object attempted to be deserialized.</throws> | ||
| /// <throws><see cref="InvalidOperationException"/>If the EventType property does not correspond to a known <see cref="EventType"/>.</throws> | ||
| public override object? ReadJson(JsonReader reader, Type objectType, object? existingValue, JsonSerializer serializer) | ||
| { | ||
| var jo = JObject.Load(reader); | ||
| int eventType = jo["EventType"]?.Value<int>() | ||
| ?? throw new JsonSerializationException("EventType missing"); | ||
|
|
||
| Type concreteType = (EventType)eventType switch | ||
| { | ||
| EventType.ExecutionStarted => typeof(ExecutionStartedEvent), | ||
| EventType.ExecutionCompleted => typeof(ExecutionCompletedEvent), | ||
| EventType.TaskScheduled => typeof(TaskScheduledEvent), | ||
| EventType.TaskCompleted => typeof(TaskCompletedEvent), | ||
| EventType.TaskFailed => typeof(TaskFailedEvent), | ||
| EventType.SubOrchestrationInstanceCreated => typeof(SubOrchestrationInstanceCreatedEvent), | ||
| EventType.SubOrchestrationInstanceCompleted => typeof(SubOrchestrationInstanceCompletedEvent), | ||
| EventType.SubOrchestrationInstanceFailed => typeof(SubOrchestrationInstanceFailedEvent), | ||
| EventType.TimerCreated => typeof(TimerCreatedEvent), | ||
| EventType.TimerFired => typeof(TimerFiredEvent), | ||
| EventType.OrchestratorStarted => typeof(OrchestratorStartedEvent), | ||
| EventType.OrchestratorCompleted => typeof(OrchestratorCompletedEvent), | ||
| EventType.EventSent => typeof(EventSentEvent), | ||
| EventType.EventRaised => typeof(EventRaisedEvent), | ||
| EventType.GenericEvent => typeof(GenericEvent), | ||
| EventType.ContinueAsNew => typeof(ContinueAsNewEvent), | ||
| EventType.ExecutionTerminated => typeof(ExecutionTerminatedEvent), | ||
| EventType.ExecutionSuspended => typeof(ExecutionSuspendedEvent), | ||
| EventType.ExecutionResumed => typeof(ExecutionResumedEvent), | ||
| EventType.ExecutionRewound => typeof(ExecutionRewoundEvent), | ||
| EventType.HistoryState => typeof(HistoryStateEvent), | ||
| _ => throw new NotSupportedException($"Unknown HistoryEvent type {eventType}") | ||
| }; | ||
|
|
||
| return jo.ToObject(concreteType, serializer); | ||
| } | ||
|
|
||
| /// <inheritdoc/> | ||
| public override void WriteJson(JsonWriter writer, object? value, JsonSerializer serializer) | ||
| { | ||
| throw new NotImplementedException(); | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We don't support write because we don't need this converter to write, right? |
||
| } | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess we would expect a PR at other backends repo? Can you link those in the PR description too when they are done?