Remove E2E test steps from GitHub Actions workflow #84
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidmrdavid
reviewed
Jun 2, 2025
Comment on lines
-45
to
-46
| - name: Run E2E tests | ||
| run: azurite --silent --blobPort 10000 --queuePort 10001 --tablePort 10002 & ./test/E2E/Start-E2ETest.ps1 -NoBuild -UseCoreToolsBuildFromIntegrationTests |
There was a problem hiding this comment.
just out of curiosity, are these tests being moved elsewhere or simply removed?
There was a problem hiding this comment.
I want to make sure we do run them somewhere, so I will follow up on this. In the meantime, we can't run them here, and this is blocking further PRs.
There was a problem hiding this comment.
Actually, I've just realized that the only problem with these tests is our attempt to use a special CoreTools build, which fails now, and which we shouldn't be doing here anyway. So, I'm dropping this PR in favor of #86
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.