Skip to content

Use TypeNameHandling.None #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Use TypeNameHandling.None #89

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2c56012
Fix flaky E2E tests
AnatoliB May 31, 2025
270ef8d
Use TypeNameHandling.None
AnatoliB Jun 3, 2025
46762da
Change TypeNameHandling to Auto for orchestration context deserializa…
AnatoliB Jun 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/DurableSDK/Commands/Internals/SetFunctionInvocationContextCommand.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ protected override void EndProcessing()
// De-serialize the orchestration context
JsonSerializerSettings serializerSettings = new JsonSerializerSettings
{
TypeNameHandling = TypeNameHandling.All
TypeNameHandling = TypeNameHandling.Auto
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this is a draft, but I recommend being very careful with this change. I remember spending a fair bit of time trying to figure out which enum value to provide here, and finding that .All was safest. But the details escape me so take it with a grain of salt.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I'm totally not going to proceed with this change, this was just a quick experiment to see which tests will fail and how they will fail.

};

var context = JsonConvert.DeserializeObject<OrchestrationContext>(OrchestrationContext, serializerSettings);
Expand Down
6 changes: 4 additions & 2 deletions test/E2E/AzureFunctions.PowerShell.Durable.SDK.E2E/DurableClientTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,8 +240,10 @@ await ValidateDurableWorkflowResults(
initialResponse,
validateIntermediateResponse: (dynamic intermediateStatusResponseBody) =>
{
Assert.Equal("Suspended", (string)intermediateStatusResponseBody.runtimeStatus);
Assert.Equal("Suspend orchestrator", (string)intermediateStatusResponseBody.output);
var runtimeStatus = (string)intermediateStatusResponseBody.runtimeStatus;
Assert.True(
runtimeStatus == "Running" || runtimeStatus == "Suspended",
$"Unexpected runtime status: {runtimeStatus}");
});

await ValidateDurableWorkflowResults(
Expand Down
5 changes: 5 additions & 0 deletions test/E2E/Start-E2ETest.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,11 @@ $Env:AZURE_FUNCTIONS_ENVIRONMENT = "Development"
$env:ExternalDurablePowerShellSDK = $true
Write-Host "Set ExternalDurablePowerShellSDK environment variable to $env:ExternalDurablePowerShellSDK"

if (-not $env:AzureWebJobsStorage) {
$env:AzureWebJobsStorage = "UseDevelopmentStorage=true"
Write-Host "Set AzureWebJobsStorage environment variable to $env:AzureWebJobsStorage"
}

$arch = [System.Runtime.InteropServices.RuntimeInformation]::OSArchitecture.ToString().ToLowerInvariant()
if ($IsWindows) {
$FUNC_EXE_NAME = "$FUNC_CMDLET_NAME.exe"
Expand Down