Skip to content

Quote event_name when raising event #435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from
+3 −2
Open

Quote event_name when raising event #435

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0407f78
Update DurableOrchestrationClient.py
waltervos May 1, 2023
337adf9
Quote event_name when wait starts, and use empty safe string
May 3, 2023
92a5bc5
Merge branch 'dev' into fix/quote_url_part
waltervos May 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion azure/durable_functions/models/DurableOrchestrationClient.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -638,7 +638,7 @@ def _get_raise_event_url(
self, instance_id: str, event_name: str,
task_hub_name: Optional[str], connection_name: Optional[str]) -> str:
request_url = f'{self._orchestration_bindings.rpc_base_url}' \
f'instances/{instance_id}/raiseEvent/{event_name}'
f'instances/{instance_id}/raiseEvent/{quote(event_name, safe="")}'

query: List[str] = []
if task_hub_name:
Expand Down
3 changes: 2 additions & 1 deletion azure/durable_functions/models/DurableOrchestrationContext.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
from collections import defaultdict
from urllib.parse import quote
from azure.durable_functions.models.actions.SignalEntityAction import SignalEntityAction
from azure.durable_functions.models.actions.CallEntityAction import CallEntityAction
from azure.durable_functions.models.Task import TaskBase, TimerTask
Expand Down Expand Up @@ -583,7 +584,7 @@ def wait_for_external_event(self, name: str) -> TaskBase:
Task to wait for the event
"""
action = WaitForExternalEventAction(name)
task = self._generate_task(action, id_=name)
task = self._generate_task(action, id_=quote(name, safe=""))
return task

def continue_as_new(self, input_: Any):
Expand Down