-
Notifications
You must be signed in to change notification settings - Fork 64
Add long timers to Python #532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GH asked for a review from me automatically, so took a peek. By no means exhaustive. This looks mostly in the right track, just left some questions. Might be worth removing me as a code owner.
Also - please triple check, in the extension and reference PRs from Hossam that I sent Chris, that there are no other "mandatory" features that the SDK needs to implement when opting in the "ooproc protocol v3". I seem to recall a that maybe "long polling callhttp" was also a requirement, or maybe it was just exposed by the extension in v3 as well. In any case, please do a check to the extension code to confirm there are no bad consequences if no changes to callhttp are made.
I also recommend adding a few unit tests here, particularly around the exception cases.
* Add long timers to Python * Add basic tests for long timers
Adds support for Long Timers in Python
Refer to this PR which added support for long timers in NodeJS, this PR is the same implementation in Python: https://github.com/Azure/azure-functions-durable-js/pull/340/files