Adopt central package management #11192
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jviau
requested review from
vrdmr,
gavin-aguiar,
hallvictoria and
a team
as code owners
liliankasem
reviewed
Jul 17, 2025
liliankasem
reviewed
Jul 17, 2025
jviau
force-pushed
the
jviau/eng/packages-props
branch
3 times, most recently
from
64d516f to
c2656ae
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR migrates the Azure Functions Host repository to use central package management via Directory.Packages.props files. The migration simplifies package version management by centralizing version definitions and leveraging MSBuild's central package management features.
Key Changes:
- Introduces central package management with Directory.Packages.props files at repository and project levels
- Removes explicit version numbers from individual project files, relying on centralized version definitions
- Standardizes StyleCop package usage across the solution while temporarily removing it from projects with warnings
- Updates MSBuild imports to use GetPathOfFileAbove for improved path resolution
Reviewed Changes
Copilot reviewed 34 out of 34 changed files in this pull request and generated 3 comments.
Show a summary per file
:
| File | Description |
|---|---|
| Directory.Packages.props | New root-level package version definitions with global StyleCop reference |
| test/Directory.Packages.props | Test-specific package versions for testing frameworks and supporting libraries |
| tools/ExtensionsMetadataGenerator/Directory.Packages.props | Tool-specific package versions with transitive pinning disabled |
| Multiple .csproj files | Removed explicit Version attributes from PackageReference elements |
| Multiple Directory.Build.* files | Updated MSBuild import paths using GetPathOfFileAbove |
| Worker .props files | Changed Version to VersionOverride for worker package references |
test/WebJobs.Script.Abstractions/WebJobs.Script.Tests.Abstractions.csproj
Outdated
Show resolved
Hide resolved
Comment on lines
15
to
17
| <PackageReference Include="Microsoft.NET.Test.Sdk" PrivateAssets="all" /> | ||
| <PackageReference Include="xunit" /> | ||
| <PackageReference Include="xunit.runner.visualstudio" PrivateAssets="all" /> |
There was a problem hiding this comment.
Extra space between attribute name and value. Should be <PackageReference Include="xunit.runner.visualstudio" PrivateAssets="all" />
Suggested change
| <PackageReference Include="Microsoft.NET.Test.Sdk" PrivateAssets="all" /> | |
| <PackageReference Include="xunit" /> | |
| <PackageReference Include="xunit.runner.visualstudio" PrivateAssets="all" /> | |
| <PackageReference Include="Microsoft.NET.Test.Sdk" PrivateAssets="all" /> | |
| <PackageReference Include="xunit" /> | |
| <PackageReference Include="xunit.runner.visualstudio" PrivateAssets="all" /> |
Copilot uses AI. Check for mistakes.
jviau
commented
Jul 21, 2025
| <ManagePackageVersionsCentrally>false</ManagePackageVersionsCentrally> | ||
| </PropertyGroup> | ||
| <!-- | ||
| <ItemGroup> |
There was a problem hiding this comment.
Put these here as I am considering pinning these, but will evaluate after
Update tests to common packaging. Address style issues Revert global.json change Remove package source mapping Add packages.props to tools Simplify some recursive imports Fix test break Update tooling package.props issues Revert NugGet.config Add newline and eof Update assert message Add delay in InitializationLogs_AreEmitted Revert style changes Apply suggestion from @Copilot Co-authored-by: Copilot <[email protected]>
jviau
force-pushed
the
jviau/eng/packages-props
branch
from
6500504 to
4a6578b
Compare
|
Rebased, working on re-syncing packages now |
jviau
force-pushed
the
jviau/eng/packages-props
branch
from
a946748 to
e295d6d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue describing the changes in this PR
resolves #10619
Pull request checklist
IMPORTANT: Currently, changes must be backported to the
in-procbranch to be included in Core Tools and non-Flex deployments.in-procbranch is not requiredrelease_notes.mdAdditional information
Migrates to central package management. Additional changes:
CentralPackageTransitivePinningEnabled=true