-
Notifications
You must be signed in to change notification settings - Fork 464
OTel related package update #11216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OTel related package update #11216
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates OpenTelemetry (OTel) related packages to newer versions, removing the Azure Monitor ASP.NET Core package and updating dependencies from v8 to v9 for several Microsoft Extensions packages.
- Replaces Azure.Monitor.OpenTelemetry.AspNetCore with Azure.Monitor.OpenTelemetry.Exporter
- Updates OpenTelemetry packages from 1.9.0 to 1.12.0
- Upgrades Microsoft.Extensions packages from 8.x to 9.x versions
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
File | Description |
---|---|
WebJobs.Script.csproj | Updates OTel package references and removes Azure Monitor ASP.NET Core dependency |
OpenTelemetryConfigurationExtensions.cs | Removes LiveMetrics configuration code to match package changes |
runtimeassemblies.json | Removes Azure.Monitor.OpenTelemetry.AspNetCore from runtime assemblies |
Test project files | Updates package references to match new versions |
release_notes.md | Documents the OTel package updates |
Comments suppressed due to low confidence (1)
src/WebJobs.Script/Diagnostics/OpenTelemetry/OpenTelemetryConfigurationExtensions.cs:229
- The removed method
ConfigureAzureMonitorOptions
forLiveMetricsExporterOptions
suggests there was previously an overload or duplicate method name. The remaining method with the same name handlesAzureMonitorExporterOptions
. Consider verifying that all calls to this method are correctly routing to the remaining overload.
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just want to confirm we are okay with the 9.x revs in regard to extension impact.
I reviewed API changes with Fabio and Matthew; we don't anticipate any issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving with one non-blocking comment.
Updating Otel related packages. This led to a major version bump in some of the dependent packages.
Issue describing the changes in this PR
resolves #11220
Pull request checklist
IMPORTANT: Currently, changes must be backported to the
in-proc
branch to be included in Core Tools and non-Flex deployments.in-proc
branch is not requiredrelease_notes.md