-
Notifications
You must be signed in to change notification settings - Fork 469
Implementing a resolver that resolves worker configurations from specified probing paths #11258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
surgupta-msft
wants to merge
82
commits into
dev
Choose a base branch
from
surgupta/dynamic-worker-resolver
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 14 commits
Commits
Show all changes
82 commits
Select commit
Hold shift + click to select a range
e18fe94
Changes to add DynamicWorkerConfigResolver
surgupta-msft 60d4414
Adding tests
surgupta-msft 5b2d5ff
Code cleanup
surgupta-msft 37ad909
Cleanup code
surgupta-msft b4ca3db
Cleanup RpcWorkerConfigFactoryTests
surgupta-msft 5bc50ee
Tests cleanup
surgupta-msft e2349e9
Tests update
surgupta-msft c86e2e7
build fix
surgupta-msft 1e9301d
Added logic to ignore worker versions specified via config
surgupta-msft 56d7918
Added test in SpecializationE2ETest
surgupta-msft 21cfe06
Updated DynamicWorkerConfigResolver
surgupta-msft d6883ab
Updated utility
surgupta-msft 3417d99
Fixed test. Added comments in resolver and options setup class
surgupta-msft c8ec8bf
Fixed FunctionsHostingConfigOptionsTest
surgupta-msft 4b344e4
Code improvement, added logs
surgupta-msft 61db33b
Addressing PR feedback
surgupta-msft 12c95da
Adding token extensions methods
surgupta-msft 15bbd31
Refactored token extensions class
surgupta-msft 47d86f1
Updating TokenExtensions
surgupta-msft 7ce1414
Reverting tokenExtensions changes
surgupta-msft 17c4209
Merge branch 'dev' into surgupta/dynamic-worker-resolver
surgupta-msft 1cbc0a7
Addressing PR feedback
surgupta-msft 74d77b2
Added tests
surgupta-msft 6f3cb9e
Addressing PR feedback, code cleanup
surgupta-msft d389a5e
Added tests for RPCWorkerConfigFactory
surgupta-msft a467a6e
Cleanup WorkerConfigurationResolverOptionsSetup
surgupta-msft 5186c44
Minor renaming, added tests
surgupta-msft 0e2056a
Minor code improvement, comments update in DynamicWorkerConfiguration…
surgupta-msft 3b5428c
Added tests in DynamicWorkerConfigurationResolverTests
surgupta-msft e91d86a
Logging and tests update
surgupta-msft adb8980
Merge branch 'dev' into surgupta/dynamic-worker-resolver
surgupta-msft 8887ee1
Added release notes
surgupta-msft 27d80d6
Addressing PR feedback, variable renaming
surgupta-msft 236ec49
Merge branch 'dev' into surgupta/dynamic-worker-resolver
surgupta-msft 8e91769
Updating reelase notes
surgupta-msft 3b1cfde
Added log and summary comment
surgupta-msft b964261
Addressing PR feedback
surgupta-msft 2afb262
Merge branch 'dev' into surgupta/dynamic-worker-resolver
surgupta-msft a680663
Resolving release notes conflict
surgupta-msft 5f84d9c
Modifying code to use config Get method
surgupta-msft d38d1c3
Using immutable objects
surgupta-msft 7002a14
Reverted RPCWorkerDescription change
surgupta-msft 669473e
Using deserialization to get HostRequirements
surgupta-msft 16b42fa
Merge branch 'dev' into surgupta/dynamic-worker-resolver
surgupta-msft b0b9e49
resolving release notes conflict
surgupta-msft 80515a3
Addressing PR comments
surgupta-msft 2109535
Fix release notes incorrect merge
surgupta-msft b3cce91
Using Config Get method to parse RPCWorkerDescription
surgupta-msft a311bf6
Merge branch 'dev' into surgupta/dynamic-worker-resolver
surgupta-msft f9504a9
Fix release notes conflict
surgupta-msft dfb1272
Fixing nits
surgupta-msft 2c2a864
Refactoring code for profile evaluation (#11301)
surgupta-msft 3434013
Merge branch 'dev' into surgupta/dynamic-worker-resolver
surgupta-msft 13f6cd2
Merge branch 'surgupta/dynamic-worker-resolver' of https://github.com…
surgupta-msft 6bb42af
Naming update
surgupta-msft 2047ec3
minor cleanup
surgupta-msft c7ec15e
Minor cleanup of DynamicWorkerConfigResolver
surgupta-msft c8982d0
Addressing PR feedback
surgupta-msft f4e1bf0
Fixing typos and comments
surgupta-msft e2ffc91
Merge branch 'dev' into surgupta/dynamic-worker-resolver
surgupta-msft cac9a74
rebase with dev
surgupta-msft d59514c
Removing redundant call to config method
surgupta-msft 7271f23
Addressing PR feedback
surgupta-msft a155b2f
Merge branch 'dev' into surgupta/dynamic-worker-resolver
surgupta-msft 21efd93
Updating release notes
surgupta-msft bc583bf
using implicit variable type
surgupta-msft 8903b5b
Minor cleanup and renaming
surgupta-msft 951f7e5
Merge branch 'dev' into surgupta/dynamic-worker-resolver
surgupta-msft 919db25
Using immutable builder
surgupta-msft 829a480
Rebase with main
surgupta-msft 4274fd5
Rebase with main
surgupta-msft c8195f1
build fix
surgupta-msft 43f2176
Fix SpecializationE2ETests failure
surgupta-msft 386fb90
Merge branch 'dev' into surgupta/dynamic-worker-resolver
surgupta-msft 9d06b5f
nit fix update
surgupta-msft 3ea50ea
Merge branch 'dev' into surgupta/dynamic-worker-resolver
surgupta-msft 401553e
release notes update
surgupta-msft febfc3c
Addressing PR feedback
surgupta-msft d082fd9
Merge branch 'dev' into surgupta/dynamic-worker-resolver
surgupta-msft a7a76bb
Addressing PR feedback
surgupta-msft 61f981b
Using base resolver class
surgupta-msft f331b38
Updating AddProvider method
surgupta-msft File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.