Conversation
7 tasks
Contributor
There was a problem hiding this comment.
Pull request overview
Adds baggage propagation support to the host→language-worker gRPC invocation contract so distributed OpenTelemetry baggage can flow into worker execution context (addressing #11026).
Changes:
- Extends
RpcTraceContextin the worker protobuf to include abaggagemap. - Populates the new
TraceContext.Baggageon invocation requests when OpenTelemetry telemetry mode is enabled.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
src/WebJobs.Script.Grpc/azure-functions-language-worker-protobuf/src/proto/FunctionRpc.proto |
Adds a new baggage field to RpcTraceContext for baggage propagation. |
src/WebJobs.Script.Grpc/Channel/GrpcWorkerChannel.cs |
Copies current baggage into the invocation request trace context when OpenTelemetry is enabled. |
src/WebJobs.Script.Grpc/azure-functions-language-worker-protobuf/src/proto/FunctionRpc.proto
Outdated
Show resolved
Hide resolved
…uf/src/proto/FunctionRpc.proto Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
satvu
commented
Feb 9, 2026
src/WebJobs.Script.Grpc/azure-functions-language-worker-protobuf/src/proto/FunctionRpc.proto
Show resolved
Hide resolved
test/WebJobs.Script.Tests/Workers/Rpc/GrpcWorkerChannelTests.cs
Outdated
Show resolved
Hide resolved
test/WebJobs.Script.Tests/Workers/Rpc/GrpcWorkerChannelTests.cs
Outdated
Show resolved
Hide resolved
RohitRanjanMS
approved these changes
Feb 10, 2026
kshyju
approved these changes
Feb 13, 2026
kshyju
reviewed
Feb 13, 2026
kshyju
reviewed
Feb 13, 2026
RohitRanjanMS
approved these changes
Feb 13, 2026
kshyju
approved these changes
Feb 13, 2026
liliankasem
approved these changes
Feb 13, 2026
Member
liliankasem
left a comment
There was a problem hiding this comment.
Changes look good, but tests should be fixed the task delay is not great and some tests require proper cleanup. Wrap setup/clear in a try/finally (or IAsyncLifetime.DisposeAsync) to keep cross-test isolation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue describing the changes in this PR
resolves #11026
Worker PR: Azure/azure-functions-dotnet-worker#3319
Pull request checklist
IMPORTANT: Currently, changes must be backported to the
in-procbranch to be included in Core Tools and non-Flex deployments.in-procbranch is not requiredrelease_notes.md