Skip to content

Conversation

@danield137
Copy link
Contributor

add field annotations

Added

Changed

  • added annotations to client_request_id, application, and user fields in ClientRequestProperties class

Fixed

add field annotations
@github-actions
Copy link
Contributor

github-actions bot commented May 15, 2025

Test Results

    6 files  ±0      6 suites  ±0   23m 30s ⏱️ + 1m 32s
  314 tests ±0    279 ✅ ±0   35 💤 ±0  0 ❌ ±0 
1 884 runs  ±0  1 674 ✅ ±0  210 💤 ±0  0 ❌ ±0 

Results for commit 5e84884. ± Comparison against base commit 5eb6b92.

♻️ This comment has been updated with latest results.

@AsafMah
Copy link
Collaborator

AsafMah commented May 18, 2025

Thanks!
It's been on the list a long time to do more annotations and fix some more.

Let me know if there are other places you need us to improve

@AsafMah
Copy link
Collaborator

AsafMah commented May 18, 2025

Note that we're using black to format, and a specific version of it to be consistent.
There's a back_to_black.bat to run it.

For now it's just a newline so I'll remove it

@AsafMah
Copy link
Collaborator

AsafMah commented May 18, 2025

If you don't like the formatting we can also type them in the ctor

@AsafMah AsafMah merged commit 7f76fb8 into master May 20, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants