Skip to content

Conversation

@AsafMah
Copy link
Collaborator

@AsafMah AsafMah commented Dec 24, 2025

Added

Changed

Fixed

@github-actions
Copy link
Contributor

github-actions bot commented Dec 24, 2025

Test Results

    5 files  ±0      5 suites  ±0   10m 53s ⏱️ + 5m 58s
  318 tests +1    283 ✅ +1   35 💤 ±0  0 ❌ ±0 
1 590 runs  +5  1 415 ✅ +5  175 💤 ±0  0 ❌ ±0 

Results for commit b764def. ± Comparison against base commit 9e97682.

♻️ This comment has been updated with latest results.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request fixes datetime column handling in older pandas versions by correcting the regex pattern used to detect dots in datetime strings and updating related test infrastructure.

Key changes:

  • Fixed regex pattern in parse_datetime to properly escape the dot character for pandas versions before 2.0
  • Changed logical operator from not to ~ for pandas boolean Series negation
  • Refactored E2E tests to create isolated tables per test instead of sharing a single table

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

File Description
azure-kusto-data/azure/kusto/data/helpers.py Fixed regex pattern from "." to "\\." and updated logical operator from not to ~ for proper pandas boolean handling; added force_version parameter for testing; updated type hints to use modern syntax
azure-kusto-data/tests/test_helpers.py Added new test test_datetime_parsing to verify datetime parsing with both pandas v1 and v2 behaviors using the force_version parameter
azure-kusto-ingest/tests/test_e2e_ingest.py Refactored test infrastructure to create unique tables per test with init_table() and drop_table() methods, removing shared table state and improving test isolation
CHANGELOG.md Documented the datetime handling fix for old pandas versions

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@AsafMah AsafMah changed the title Fixes pandas date method Fixes pandas date method + fix ingest tests race conditions Dec 25, 2025
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please commit the suggested changes from markdownlint.

AsafMah and others added 2 commits December 25, 2025 09:48
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please commit the suggested changes from markdownlint.

yogilad
yogilad previously approved these changes Dec 25, 2025
@AsafMah AsafMah merged commit 5259589 into master Dec 25, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants