-
Notifications
You must be signed in to change notification settings - Fork 110
Fixes pandas date method + fix ingest tests race conditions #615
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This pull request fixes datetime column handling in older pandas versions by correcting the regex pattern used to detect dots in datetime strings and updating related test infrastructure.
Key changes:
- Fixed regex pattern in
parse_datetimeto properly escape the dot character for pandas versions before 2.0 - Changed logical operator from
notto~for pandas boolean Series negation - Refactored E2E tests to create isolated tables per test instead of sharing a single table
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| azure-kusto-data/azure/kusto/data/helpers.py | Fixed regex pattern from "." to "\\." and updated logical operator from not to ~ for proper pandas boolean handling; added force_version parameter for testing; updated type hints to use modern syntax |
| azure-kusto-data/tests/test_helpers.py | Added new test test_datetime_parsing to verify datetime parsing with both pandas v1 and v2 behaviors using the force_version parameter |
| azure-kusto-ingest/tests/test_e2e_ingest.py | Refactored test infrastructure to create unique tables per test with init_table() and drop_table() methods, removing shared table state and improving test isolation |
| CHANGELOG.md | Documented the datetime handling fix for old pandas versions |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please commit the suggested changes from markdownlint.
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please commit the suggested changes from markdownlint.
Added
Changed
Fixed