[Instant Access DD Snapshot] Pre Snapshot and Do Snapshot API Changes #2121
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prchingh
approved these changes
Nov 17, 2025
prchingh
left a comment
prchingh
left a comment
There was a problem hiding this comment.
@arisettisanjana Pls, review these PRs as well for IA related feature code in extensions
There was a problem hiding this comment.
Do we need any changes in processing the response from BHS, generally in Linux extension code what do we follow??
| ddSnapshotIdentifierInfo = HostSnapshotObjects.DDSnapshotIdentifier(creationTimeUTCTicks , snapshot_info['ddSnapshotIdentifier']['id'], snapshot_info['ddSnapshotIdentifier']['token']) | ||
| creationTimeUTCTicks = str(int(timestamp * 1000)) | ||
| instantAccessDurationMinutes = None | ||
| if 'instantAccessDurationMinutes' in snapshot_info['ddSnapshotIdentifier']: |
Contributor
There was a problem hiding this comment.
can we use the constant instantAccessDurationMinutes defined in common.py in lines 236 and 237 also while accessing the property
arisettisanjana
approved these changes
Nov 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task 32983493, 35720465