Avoid throwing exception on decrypt failure #2129
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The decryption logic was throwing
OSErrorexceptions whenopenssl cmsoropenssl smimecommands failed, causing the handler to crash instead of gracefully handling decryption failures.Changes
waagent.RunSendStdin()calls in try-except blocks to catchOSErrorexceptionsopenssl cmsfirst (FIPS 140-3 compliant), then falls back toopenssl smimeif the first failsThe handler now continues execution even if both decryption methods fail, allowing the extension to handle missing protected settings appropriately rather than crashing.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.