[app service] adding database connection #812

KarishmaGhiya · 2025-08-01T22:43:49Z

What does this PR do?

Adding database connection to webapp

[Any additional context, screenshots, or information that helps reviewers]

GitHub issue number?

[Link to the GitHub issue this PR addresses]

Pre-merge Checklist

Copilot

Pull Request Overview

This PR adds database connection functionality to the Azure App Service area, allowing users to configure database connections for web applications through the MCP tool. The implementation includes support for multiple database types (SQL Server, MySQL, PostgreSQL, CosmosDB) with automatic connection string generation.

Key changes:

Implements App Service database connection commands and services
Adds comprehensive test coverage for both unit and live testing scenarios
Updates documentation with new command examples and parameters

Reviewed Changes

Copilot reviewed 26 out of 26 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
docs/azmcp-commands.md	Documents new appservice database add command with examples and parameters
areas/appservice/tests/test-resources.bicep	Defines test infrastructure for App Service and database resources
areas/appservice/tests/AzureMcp.AppService.UnitTests/*	Unit tests for AppServiceService and DatabaseAddCommand
areas/appservice/tests/AzureMcp.AppService.LiveTests/*	Live integration tests for database commands
areas/appservice/src/AzureMcp.AppService/*	Core implementation including services, commands, models, and options
Directory.Packages.props	Adds Xunit.SkippableFact package dependency
.vscode/cspell.json	Adds spell check entries for appservice and sqlserver

Copilot · 2025-08-08T23:41:56Z

areas/appservice/src/AzureMcp.AppService/Commands/Database/DatabaseAddCommand.cs

+    {
+        var options = BindOptions(parseResult);
+
+        try


The CHANGELOG.md file needs to be updated to document this new database connection functionality. Add an entry describing the new appservice database add command in the appropriate release section.

areas/appservice/src/AzureMcp.AppService/Services/AppServiceService.cs

Directory.Packages.props

areas/appservice/src/AzureMcp.AppService/Options/AppServiceOptionDefinitions.cs

areas/appservice/src/AzureMcp.AppService/Services/AppServiceService.cs

jongio · 2025-08-08T23:45:26Z

areas/appservice/tests/test-resources.bicep

+}
+
+// SQL Server
+resource sqlServer 'Microsoft.Sql/servers@2023-05-01-preview' = {


We should consider if we use the sql from the /sql folder. I'm not sure if the deploy-testresources is setup to do dependencies, but I would like to not have to provision to sql servers and databases unless absolutely necessary.

docs/azmcp-commands.md

jongio · 2025-08-08T23:46:51Z

docs/azmcp-commands.md

- Service availability issues
- Authentication errors
+-   Service availability issues
+-   Authentication errors


Also need to add to e2eprompts.md. Make sure you ask copilot to verify your PR against the checklist in new-command.md

vcolin7 · 2025-08-11T21:17:06Z

areas/appservice/src/AzureMcp.AppService/Commands/Database/DatabaseAddCommand.cs

+        """
+        Add a database connection to an App Service. This command configures database connection
+        settings for the specified App Service, allowing it to connect to a database server.
+        """;


Have you tried running the utility in eng\tools\ToolDescriptionConfidenceScore to see if the description is good enough? You can find instructions on how to do that here :)

vcolin7 · 2025-08-11T21:17:28Z

areas/appservice/src/AzureMcp.AppService/Commands/Database/DatabaseAddCommand.cs

+    {
+        var options = BindOptions(parseResult);
+
+        try


vcolin7 · 2025-08-11T21:19:01Z

areas/appservice/src/AzureMcp.AppService/Commands/Database/DatabaseAddCommand.cs

+        return context.Response;
+    }
+
+    public record Result(DatabaseConnectionInfo ConnectionInfo);


We've been making the names of these records pretty verbose/descriptive. Should we use Result instead @jongio? After all, if we ever use them in other classes we could do so by using DatabaseAddCommand.Result, for example.

areas/appservice/src/AzureMcp.AppService/Services/AppServiceService.cs

areas/appservice/tests/AzureMcp.AppService.LiveTests/Services/AppServiceServiceLiveTests.cs

areas/appservice/tests/AzureMcp.AppService.UnitTests/Services/AppServiceServiceTests.cs

.../appservice/tests/AzureMcp.AppService.UnitTests/Commands/Database/DatabaseAddCommandTests.cs

vcolin7 · 2025-08-11T21:59:03Z

.../appservice/tests/AzureMcp.AppService.UnitTests/Commands/Database/DatabaseAddCommandTests.cs

+
+        // Assert
+        Assert.NotNull(response);
+        Assert.NotEqual(200, response.Status);


I think the response code on an error is 500. We should probably compare against that. Not 200 could be 201, which is still successful according to the REST spec.

…kage instead

…rvice.cs Co-authored-by: Copilot <[email protected]>

jongio · 2025-08-25T19:00:12Z

Sorry for the inconvenience, but we have moved the Azure MCP Server source code to https://github.com/microsoft/mcp. This change allows us to build any Microsoft MCP server with the same engineering system and allows us to brand any MCP server with either Azure or Microsoft branding. This repo change means that you need to move this PR to that new repo. Please do so and then add a link here to that new PR. We'll close this PR now and we look forward to seeing this over on the new repo.

github-project-automation bot added this to Azure MCP Server (OLD) Aug 1, 2025

github-project-automation bot moved this to Untriaged in Azure MCP Server (OLD) Aug 1, 2025

KarishmaGhiya moved this from Untriaged to In Progress in Azure MCP Server (OLD) Aug 1, 2025

KarishmaGhiya mentioned this pull request Aug 1, 2025

[app service] adding database connection #518

Closed

9 tasks

KarishmaGhiya marked this pull request as ready for review August 8, 2025 23:40

Copilot AI review requested due to automatic review settings August 8, 2025 23:40

KarishmaGhiya requested a review from a team as a code owner August 8, 2025 23:40

KarishmaGhiya requested review from hallipr, joshfree, jongio, g2vinay, conniey, JonathanCrd and alzimmermsft August 8, 2025 23:40

Copilot AI reviewed Aug 8, 2025

View reviewed changes

jongio suggested changes Aug 8, 2025

View reviewed changes

KarishmaGhiya force-pushed the app-service-database branch from 022052a to be5215f Compare August 8, 2025 23:49

vcolin7 suggested changes Aug 11, 2025

View reviewed changes

KarishmaGhiya added 12 commits August 19, 2025 17:45

update

e03b74a

format

a8c120d

formatting

23dcc57

add bicep file

2a7dab3

add to cspell

9003a98

update

1e28571

add

123cb33

formatting and added tests for documentation updates

eadf325

added documentation tests

c14f586

add updates to app service code to not use simulatio nand use ARM pac…

ded97d8

…kage instead

add updates to live tests and unit tests

fed5b67

fix doc tests

f627b5d

KarishmaGhiya and others added 7 commits August 19, 2025 17:53

add set up for app service in core

595f500

update code

22d30c4

consolidate tests

bfa309a

consolidate tests

3bcfb0a

removed unnecessary tests

9d236a1

Update areas/appservice/src/AzureMcp.AppService/Services/AppServiceSe…

a8e2f2e

…rvice.cs Co-authored-by: Copilot <[email protected]>

Update areas/appservice/src/AzureMcp.AppService/Services/AppServiceSe…

161e2cc

…rvice.cs Co-authored-by: Copilot <[email protected]>

KarishmaGhiya force-pushed the app-service-database branch from b684b35 to 161e2cc Compare August 20, 2025 00:53

KarishmaGhiya added 8 commits August 20, 2025 18:12

removed bug

327cc02

Added license

c3b86a5

removed unnecessary package

46f6a1c

remove -name from the parameters

a9cf3b1

undo weird formatting

121ac47

undo weird formatting

692ce49

consolidate tests

046ae78

add testing

63cb695

jongio assigned KarishmaGhiya Aug 21, 2025

jongio closed this Aug 25, 2025

github-project-automation bot moved this from In Progress to Done in Azure MCP Server (OLD) Aug 25, 2025

KarishmaGhiya mentioned this pull request Aug 26, 2025

App service add database tool microsoft/mcp#59

Open

16 tasks

[app service] adding database connection #812

[app service] adding database connection #812

Uh oh!

Conversation

KarishmaGhiya commented Aug 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

GitHub issue number?

Pre-merge Checklist

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Aug 8, 2025

Choose a reason for hiding this comment

Uh oh!

vcolin7 Aug 11, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jongio Aug 8, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

jongio Aug 8, 2025

Choose a reason for hiding this comment

Uh oh!

vcolin7 Aug 11, 2025

Choose a reason for hiding this comment

Uh oh!

vcolin7 Aug 11, 2025

Choose a reason for hiding this comment

Uh oh!

vcolin7 Aug 11, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

vcolin7 Aug 11, 2025

Choose a reason for hiding this comment

Uh oh!

jongio commented Aug 25, 2025

Uh oh!

Uh oh!

KarishmaGhiya commented Aug 1, 2025 •

edited

Loading