-
Notifications
You must be signed in to change notification settings - Fork 338
Updated Bicep tool to depend on latest Azure.Bicep.Types (0.6.1) and Azure.Bicep.Types.Az (0.2.792) versions #893
Conversation
…ed test to correspond to new parameter
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the Azure Bicep Types dependencies to their latest versions (0.6.1 and 0.2.792) to enable AOT compliance. The changes refactor the ResourceTypeEntity class to align with the new scope parameters introduced in the updated packages.
- Updated package versions for Azure.Bicep.Types and Azure.Bicep.Types.Az
- Refactored ResourceTypeEntity to use new scope properties (WritableScopes/ReadableScopes) instead of legacy ScopeType/Flags
- Updated corresponding test expectations to match the new property structure
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
File | Description |
---|---|
Directory.Packages.props | Updated Azure.Bicep.Types package versions to latest releases |
ResourceTypeEntity.cs | Refactored to use new WritableScopes/ReadableScopes properties instead of deprecated Flags/ScopeType |
ResourceVisitor.cs | Updated property mapping to use new scope properties from updated packages |
GetSchemaTests.cs | Updated test expectations for new scope property structure |
EntitySerializationTests.cs | Updated serialization test expectations for refactored properties |
CHANGELOG.md | Added entry documenting the package updates |
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
...epschema/src/AzureMcp.BicepSchema/Services/ResourceProperties/Entities/ResourceTypeEntity.cs
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requesting change specifically on the missing AzureMcp.Cli.csproj edit
areas/bicepschema/src/AzureMcp.BicepSchema/Services/ResourceProperties/ResourceVisitor.cs
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
THANK YOU!!!
…Azure.Bicep.Types.Az (0.2.792) versions (Azure#893) * update bicep version * update tests * update bicep * Updated versions of Azure.Bicep.Types and Azure.Bicep.Types.Az, updated test to correspond to new parameter * Updated format of changelog and included Bicep tools in Native (AOT) build
* Add get command to readme and changelog * Add function app details command to documentation and test prompts * Move function app list tests into functionapp folder * Implement GetFunctionApp service method * Add global usings for System.CommandLine and AzureMcp.Core.Options * Move function app list options to function app folder * Update namespace * Removed unused reference * Create base function app options * Create get function app options * remove unused reference from base function app command * Add FunctionAppGetCommand to retrieve Azure Function App details * Add FunctionAppGetCommand and related options for retrieving Function App details * Add unit tests for FunctionAppGetCommand to validate input and response handling * Add live tests for retrieving specific Function App details and handling errors * Update function app prompt to remove resource group specification * Fix cross-platform artifact detection in Run-ToolDescriptionConfidenceScore.ps1 * Update option name from 'functionapp' to 'function-app' for consistency across code and documentation * Address formatting * Fix links in CHANGELOG for Azure Function App commands and cross-platform bug * Improve get command description * Formatting and update unit tests * Fix typo in CHANGELOG * Fix command-line argument naming in FunctionAppGetCommandTests * Fix command-line argument naming for function app in tests * Fix indentation in FunctionAppGetCommandTests * Apply suggestion from @Copilot Co-authored-by: Copilot <[email protected]> * Update e2e prompts to be ordered alphabetically * Update azmcp-commands to be ordered alphabetically for function apps * Update description based on feedback * Fix copilot merge issue * Increment version after release (#984) * Updated scoring metrics and renamed utility for evaluating tool descriptions (#965) * Updated scoring metrics and results * Renamed the utility to ToolDescriptionEvaluator * Added licensing header to .cs files * Update README with SSE deprecation notice (#994) Update README with SSE deprecation notice * Move e2etestprompts.md to docs (#992) * Updated Bicep tool to depend on latest Azure.Bicep.Types (0.6.1) and Azure.Bicep.Types.Az (0.2.792) versions (#893) * update bicep version * update tests * update bicep * Updated versions of Azure.Bicep.Types and Azure.Bicep.Types.Az, updated test to correspond to new parameter * Updated format of changelog and included Bicep tools in Native (AOT) build * Onboarding the Azure Service Health & Adding the resourcehealth availability-status get & resourcehealth availability-status list tools (#998) * Onboarding the Azure Service Health & Adding the resourcehealth availability-status get & resourcehealth availability-status list tools * Fix ResourceHealth unit test validation and AOT compatibility * Remove ResourceHealth live tests and test infrastructure * Fix Extension.UnitTests: Correct mock method signatures for IExternalProcessService.ExecuteAsync * Add NOTICE.txt and include in build output (#996) * Fix changelog due to merging * Undo changes to .env.example * Re-ran evaluator tool --------- Co-authored-by: Copilot <[email protected]> Co-authored-by: Azure SDK Bot <[email protected]> Co-authored-by: vcolin7 <[email protected]> Co-authored-by: Josh Free <[email protected]> Co-authored-by: Jon Gallant <[email protected]> Co-authored-by: msalaman <[email protected]> Co-authored-by: pkaza-msft <[email protected]> Co-authored-by: Patrick Hallisey <[email protected]>
What does this PR do?
Update package versions of Azure.Bicep.Types (0.6.1) and Azure.Bicep.Types.Az (0.2.792) to include AOT compliant changes made to those packages. Refactor ResourceTypeEntity to correspond with new scope parameters introduced by the new package upgrade
GitHub issue number?
[Link to the GitHub issue this PR addresses]
Pre-merge Checklist
CHANGELOG.md
for product changes (features, bug fixes, UI/UX, updated dependencies
).\eng\common\spelling\Invoke-Cspell.ps1
README.md
documentation/docs/azmcp-commands.md
/e2eTests/e2eTestPrompts.md
eng/tools/ToolDescriptionConfidenceScore
tool and obtained a result >= 0.4crypto mining, spam, data exfiltration, etc.
)/azp run azure - mcp
to run Live Test Pipeline