Skip to content
This repository was archived by the owner on Sep 4, 2025. It is now read-only.

Conversation

msalaman
Copy link
Contributor

@msalaman msalaman commented Aug 7, 2025

What does this PR do?

Update package versions of Azure.Bicep.Types (0.6.1) and Azure.Bicep.Types.Az (0.2.792) to include AOT compliant changes made to those packages. Refactor ResourceTypeEntity to correspond with new scope parameters introduced by the new package upgrade

GitHub issue number?

[Link to the GitHub issue this PR addresses]

Pre-merge Checklist

  • Required for All PRs
    • Read contribution guidelines
    • PR title clearly describes the change
    • Commit history is clean with descriptive messages (cleanup guide)
    • Added comprehensive tests for new/modified functionality
    • Updated CHANGELOG.md for product changes (features, bug fixes, UI/UX, updated dependencies)
    • Spelling check passes: .\eng\common\spelling\Invoke-Cspell.ps1
  • For MCP tool changes:
    • Updated README.md documentation
    • Updated command list in /docs/azmcp-commands.md
    • Updated test prompts in /e2eTests/e2eTestPrompts.md
    • For new or modified tool descriptions, ran the eng/tools/ToolDescriptionConfidenceScore tool and obtained a result >= 0.4
  • 👉 For Community (non-Azure team member) PRs:
    • Security review: Reviewed code for security vulnerabilities, malicious code, or suspicious activities before running tests (crypto mining, spam, data exfiltration, etc.)
    • Manual tests run: added comment /azp run azure - mcp to run Live Test Pipeline

@msalaman msalaman changed the title Masalama/upgrade bicep Updated Bicep tool to depend on latest Azure.Bicep.Types (0.6.1) and Azure.Bicep.Types.Az (0.2.792) versions Aug 15, 2025
@msalaman msalaman marked this pull request as ready for review August 15, 2025 20:57
@Copilot Copilot AI review requested due to automatic review settings August 15, 2025 20:57
@msalaman msalaman requested a review from a team as a code owner August 15, 2025 20:57
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the Azure Bicep Types dependencies to their latest versions (0.6.1 and 0.2.792) to enable AOT compliance. The changes refactor the ResourceTypeEntity class to align with the new scope parameters introduced in the updated packages.

  • Updated package versions for Azure.Bicep.Types and Azure.Bicep.Types.Az
  • Refactored ResourceTypeEntity to use new scope properties (WritableScopes/ReadableScopes) instead of legacy ScopeType/Flags
  • Updated corresponding test expectations to match the new property structure

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
Directory.Packages.props Updated Azure.Bicep.Types package versions to latest releases
ResourceTypeEntity.cs Refactored to use new WritableScopes/ReadableScopes properties instead of deprecated Flags/ScopeType
ResourceVisitor.cs Updated property mapping to use new scope properties from updated packages
GetSchemaTests.cs Updated test expectations for new scope property structure
EntitySerializationTests.cs Updated serialization test expectations for refactored properties
CHANGELOG.md Added entry documenting the package updates

You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.

Copy link
Member

@joshfree joshfree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting change specifically on the missing AzureMcp.Cli.csproj edit

@github-project-automation github-project-automation bot moved this from Untriaged to In Progress in Azure MCP Server (OLD) Aug 15, 2025
Copy link
Member

@joshfree joshfree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

THANK YOU!!!

@joshfree joshfree merged commit 9d08dcd into main Aug 15, 2025
26 checks passed
@joshfree joshfree deleted the masalama/upgradeBicep branch August 15, 2025 22:41
@github-project-automation github-project-automation bot moved this from In Progress to Done in Azure MCP Server (OLD) Aug 15, 2025
colbytimm pushed a commit to colbytimm/azure-mcp that referenced this pull request Aug 18, 2025
…Azure.Bicep.Types.Az (0.2.792) versions (Azure#893)

* update bicep version

* update tests

* update bicep

* Updated versions of Azure.Bicep.Types and Azure.Bicep.Types.Az, updated test to correspond to new parameter

* Updated format of changelog and included Bicep tools in Native (AOT) build
vcolin7 added a commit that referenced this pull request Aug 21, 2025
* Add get command to readme and changelog

* Add function app details command to documentation and test prompts

* Move function app list tests into functionapp folder

* Implement GetFunctionApp service method

* Add global usings for System.CommandLine and AzureMcp.Core.Options

* Move function app list options to function app folder

* Update namespace

* Removed unused reference

* Create base function app options

* Create get function app options

* remove unused reference from base function app command

* Add FunctionAppGetCommand to retrieve Azure Function App details

* Add FunctionAppGetCommand and related options for retrieving Function App details

* Add unit tests for FunctionAppGetCommand to validate input and response handling

* Add live tests for retrieving specific Function App details and handling errors

* Update function app prompt to remove resource group specification

* Fix cross-platform artifact detection in Run-ToolDescriptionConfidenceScore.ps1

* Update option name from 'functionapp' to 'function-app' for consistency across code and documentation

* Address formatting

* Fix links in CHANGELOG for Azure Function App commands and cross-platform bug

* Improve get command description

* Formatting and update unit tests

* Fix typo in CHANGELOG

* Fix command-line argument naming in FunctionAppGetCommandTests

* Fix command-line argument naming for function app in tests

* Fix indentation in FunctionAppGetCommandTests

* Apply suggestion from @Copilot

Co-authored-by: Copilot <[email protected]>

* Update e2e prompts to be ordered alphabetically

* Update azmcp-commands to be ordered alphabetically for function apps

* Update description based on feedback

* Fix copilot merge issue

* Increment version after release (#984)

* Updated scoring metrics and renamed utility for evaluating tool descriptions (#965)

* Updated scoring metrics and results

* Renamed the utility to ToolDescriptionEvaluator

* Added licensing header to .cs files

* Update README with SSE deprecation notice (#994)

Update README with SSE deprecation notice

* Move e2etestprompts.md to docs (#992)

* Updated Bicep tool to depend on latest Azure.Bicep.Types (0.6.1) and Azure.Bicep.Types.Az (0.2.792) versions (#893)

* update bicep version

* update tests

* update bicep

* Updated versions of Azure.Bicep.Types and Azure.Bicep.Types.Az, updated test to correspond to new parameter

* Updated format of changelog and included Bicep tools in Native (AOT) build

* Onboarding the Azure Service Health & Adding the resourcehealth availability-status get & resourcehealth availability-status list tools (#998)

* Onboarding the Azure Service Health & Adding the resourcehealth availability-status get & resourcehealth availability-status list tools

* Fix ResourceHealth unit test validation and AOT compatibility

* Remove ResourceHealth live tests and test infrastructure

* Fix Extension.UnitTests: Correct mock method signatures for IExternalProcessService.ExecuteAsync

* Add NOTICE.txt and include in build output (#996)

* Fix changelog due to merging

* Undo changes to .env.example

* Re-ran evaluator tool

---------

Co-authored-by: Copilot <[email protected]>
Co-authored-by: Azure SDK Bot <[email protected]>
Co-authored-by: vcolin7 <[email protected]>
Co-authored-by: Josh Free <[email protected]>
Co-authored-by: Jon Gallant <[email protected]>
Co-authored-by: msalaman <[email protected]>
Co-authored-by: pkaza-msft <[email protected]>
Co-authored-by: Patrick Hallisey <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants