This repository was archived by the owner on Sep 4, 2025. It is now read-only.
Add Azure Container Registry (ACR) support (acr list) #915
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jongio
requested review from
a team,
vurhanau,
xiangyan99,
alzimmermsft,
philon-msft,
anuchandy,
conniey,
srnagar,
meirloichter,
danield137,
jayanthjj,
vcolin7,
JonathanCrd,
weng5e,
wbreza,
sajeetharan and
g2vinay
as code owners
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
anuchandy
reviewed
Aug 8, 2025
…nality - Introduced ACR commands and services for managing Azure Container Registries. - Implemented `azmcp-acr-registry-list` command to list all registries in a subscription or specific resource group. - Added necessary options and context for ACR commands. - Updated documentation to include ACR prompts and usage examples. - Created unit and live tests to ensure functionality and error handling for ACR commands.
…tion for ACR support
Co-authored-by: Copilot <[email protected]>
…i.csproj and update area registration in Program.cs
vcolin7
reviewed
Aug 11, 2025
vcolin7
reviewed
Aug 11, 2025
…ts and documentation
There was a problem hiding this comment.
Pull Request Overview
This PR introduces comprehensive support for Azure Container Registry (ACR) functionality by adding a complete acr area to the Azure MCP server. The implementation provides commands for listing container registries with optional resource group filtering.
- Implements ACR registry list command with subscription and optional resource group filtering
- Adds complete test infrastructure including Bicep templates for live testing
- Provides both unit and integration tests with proper RBAC configuration
Reviewed Changes
Copilot reviewed 224 out of 224 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| eng/vscode/README.md | Added ACR service area with example prompts for listing container registries |
| e2eTests/e2eTestPrompts.md | Added test prompts for ACR registry list command validation |
| docs/new-command.md | Updated documentation with new test infrastructure requirements and patterns |
| docs/azmcp-commands.md | Added ACR command examples showing registry list usage |
| core/src/AzureMcp.Cli/Program.cs | Registered ACR area setup under BuildNative condition |
| core/src/AzureMcp.Cli/AzureMcp.Cli.csproj | Excluded ACR project from native builds due to AOT compatibility |
| areas/acr/tests/test-resources.bicep | Bicep template for ACR test infrastructure with proper RBAC roles |
| areas/acr/tests/test-resources-post.ps1 | Post-deployment script for test resource configuration |
| areas/acr/src/AzureMcp.Acr/* | Complete ACR implementation with commands, services, models, and options |
| Multiple GlobalUsings.cs files | Cleaned up unused using statements across various areas |
Co-authored-by: Copilot <[email protected]>
alzimmermsft
approved these changes
Aug 12, 2025
github-project-automation
bot
moved this from Untriaged
to Done
in Azure MCP Server (OLD)
chidozieononiwu
pushed a commit
to chidozieononiwu/azure-mcp
that referenced
this pull request
Aug 18, 2025
* feat: Add Azure Container Registry (ACR) support with listing functionality - Introduced ACR commands and services for managing Azure Container Registries. - Implemented `azmcp-acr-registry-list` command to list all registries in a subscription or specific resource group. - Added necessary options and context for ACR commands. - Updated documentation to include ACR prompts and usage examples. - Created unit and live tests to ensure functionality and error handling for ACR commands. * feat: Add test infrastructure for Azure Container Registry with role assignments * feat: Update CODEOWNERS and LiveTests project configuration documentation for ACR support * Update changelog * Update eng/vscode/README.md Co-authored-by: Copilot <[email protected]> * feat: Add "myproject" to custom words in cspell configuration * feat: Add mandatory post-deployment script for Azure service commands * feat: Exclude non-AOT safe projects from native builds in AzureMcp.Cli.csproj and update area registration in Program.cs * test: Update invalid input test cases in AcrCommandTests to improve clarity * feat: Add ACR registry listing command and related models, update tests and documentation * feat: Add 'myregistry' to cspell dictionary * Update eng/vscode/README.md Co-authored-by: Copilot <[email protected]> --------- Co-authored-by: Copilot <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce support for Azure Container Registry, including commands for listing registries and managing role assignments. Update documentation and enhance test infrastructure to ensure robust functionality. Adjust project configurations to accommodate ACR features.
Fixes #907