-
Notifications
You must be signed in to change notification settings - Fork 338
Add native AOT compile verification #920
Conversation
b24ad4e
to
2ab8862
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but maybe we should get @hallipr or @weshaggard to take a look before merging.
What is different between this and "Run AOT Compatibility Analysis"? Aren't they both trying to do this analysis? |
@weshaggard, the main difference is -
So, while 1 let’s know the entire state of the repro without failing but as warnings, the 2 ensure the areas marked to ship as AOT is really safe or fail the pr otherwise. The plan is to ship the "native binary" (for the subset of AOT safe areas) side-by-side with the .NET-based one for dogfooding. Once the entire repo is AOT-safe, we'll ship only the native binary (as mentioned in Josh’s email last Friday). This PR is the first step toward that goal. |
2ab8862
to
3faf0a6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds Native AOT (Ahead-of-Time) compilation verification to the CI pipeline to catch compatibility issues early. The verification runs on Linux x64 during PR builds to ensure the codebase remains AOT-compatible.
- Adds a new build step in the CI pipeline that performs Native AOT compilation
- Modifies the build script to support Native AOT builds and clean up artifacts
- Includes build artifact cleanup to ensure clean builds
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
File | Description |
---|---|
eng/scripts/Build-Module.ps1 | Refactors project path variables and adds cleanup of build artifacts |
eng/pipelines/templates/jobs/build.yml | Adds new Native AOT build verification step to the CI pipeline |
3faf0a6
to
1aa7b06
Compare
1aa7b06
to
33c5072
Compare
* Add native aot compile verification (only on linux arm64) * compile on all arch, use temp dir * add clean-build param
What does this PR do?
[Provide a clear, concise description of the changes]
Add Native AOT build verification to CI to catch compatibility issues on PRs.
[Any additional context, screenshots, or information that helps reviewers]
GitHub issue number?
[Link to the GitHub issue this PR addresses]
Pre-merge Checklist
CHANGELOG.md
for product changes (features, bug fixes, UI/UX, updated dependencies
).\eng\common\spelling\Invoke-Cspell.ps1
README.md
documentation/docs/azmcp-commands.md
/e2eTests/e2eTestPrompts.md
eng/tools/ToolDescriptionConfidenceScore
tool and obtained a result >= 0.4crypto mining, spam, data exfiltration, etc.
)/azp run azure - mcp
to run Live Test Pipeline