Communication sms #921
Communication sms #921
Conversation
| : GlobalCommand<TOptions> | ||
| where TOptions : BaseCommunicationOptions, new() | ||
| { | ||
| protected readonly Option<string> _connectionStringOption = CommunicationOptionDefinitions.ConnectionString; |
There was a problem hiding this comment.
Are there secret values in this connection string? If so, then get it from the mgmt plane using libs instead of exposing as a param.
There was a problem hiding this comment.
Maybe. usually connection strings are secrets
Directory.Packages.props
Outdated
| @@ -7,6 +7,7 @@ | |||
| <PackageVersion Include="Azure.Bicep.Types" Version="0.5.110" /> | |||
| <PackageVersion Include="Azure.Bicep.Types.Az" Version="0.2.771" /> | |||
| <PackageVersion Include="Azure.Core" Version="1.47.1" /> | |||
| <PackageVersion Include="Azure.Communication.Sms" Version="1.0.0" /> | |||
There was a problem hiding this comment.
I wonder if 'send sms message' from copilot is a valid scenario that a developer would do. Do we have a request for this?
There was a problem hiding this comment.
What about Agents -- we'll be used by at least Azure AI Foundry Agents and CoPilot Studio Agents in the future.
CoPilot Studio (graphical system, for non-programmers who want to have Assistant Agents running on Website chat sessions, Facebook, Instagram, etc) may want this, but I dont know.
There was a problem hiding this comment.
There was a problem hiding this comment.
@joshfree communication-chat is a different library though atleast in Typescript
|
/azp run azure - mcp |
|
Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command. |
KarishmaGhiya
force-pushed
the
communication-sms
branch
from
c948ce0 to
99396c2
Compare
|
/azp run azure - mcp |
|
Azure Pipelines successfully started running 1 pipeline(s). |
KarishmaGhiya
force-pushed
the
communication-sms
branch
from
38a54fa to
896dd95
Compare
|
Sorry for the inconvenience, but we have moved the Azure MCP Server source code to https://github.com/microsoft/mcp. This change allows us to build any Microsoft MCP server with the same engineering system and allows us to brand any MCP server with either Azure or Microsoft branding. This repo change means that you need to move this PR to that new repo. Please do so and then add a link here to that new PR. We'll close this PR now and we look forward to seeing this over on the new repo. |
github-project-automation
bot
moved this from Untriaged
to Done
in Azure MCP Server (OLD)
What does this PR do?
[Provide a clear, concise description of the changes][Any additional context, screenshots, or information that helps reviewers]GitHub issue number?
[Link to the GitHub issue this PR addresses]Pre-merge Checklist
CHANGELOG.mdfor product changes (features, bug fixes, UI/UX, updated dependencies).\eng\common\spelling\Invoke-Cspell.ps1README.mddocumentation/docs/azmcp-commands.md/e2eTests/e2eTestPrompts.mdeng/tools/ToolDescriptionConfidenceScoretool and obtained a result >= 0.4crypto mining, spam, data exfiltration, etc.)/azp run azure - mcpto run Live Test Pipeline