Feature/fcmv1

[rextor92]

Description

I have added the newly created SendFcmV1NativeNotificationAsync methods to the INotificationHubClient so that we can continue mocking a client in projects after updating.

Also added some FCMv1 tests with the new payload structure for notifications.

Related PRs or issues

Fixes #307
Relates to #110

Misc

• Upon running the tests without Notification Hub settings in appconfig.json (in RecordingMode.Playback), the newly added tests will fail as there are no files in MockData. I have ran the tests with my notification hub (RecordingMode.Recording) and can add the necessary files, but I am unsure whether you'd want to do it yourself against the sdk-sample-namespace ANH?
• We are not just adding FCMv1 support here, GCM/FCM will be disabled on July 1st, 2024. I would like to add deprecated tags on the relevant methods - as in the Java implementation of the change. I am thinking of something like
  [Obsolete("SendFcmNativeNotificationAsync will be deprecated on July 1st, 2024. Please use SendFcmV1NativeNotificationAsync instead.")]
• We'll also have to bump the package version to 4.2.1

---

Things to consider before you submit the PR:

• Are tests passing locally?
• Are the files formatted correctly?
• Did you add unit tests?
• Did you test your change with either the sample apps that are included in the repository or with a blank app that uses your change?

[rextor92]

@microsoft-github-policy-service agree

[developer9969]

hi - would it possible to know when this will be merged?

[rextor92]

It's been sitting with some open questions for a while. I can see @jessHuh is typically assigned to review some recent PRs.

[developer9969]

ok - is it a case of lack of time for @jessHuh to have a look at this and move it forward?

[developer9969]

Greatly appreciated if this could be reviewed

[developer9969]

this is just a joke now - Common what is the problem not even the bliming courtesy to say something

[lomagdal2]

@rextor92 looks good.

No need for you to upload your test files. Go ahead and add the deprecation tags. Yes, package will be bumped to 4.2.1.

After you push up your changes I will sign off on this PR.

[gabsamples6]

Hi - why does it take sooooo long to merge this one and push a new nuget??? It would help to know @lomagdal2

[TedMobile]

Any chance of this pull request being merged? Many thanks

[MiloszKowalski]

@lomagdal2, @rextor92

Could you please merge this PR? It's been a while since it's been created and it already has an approve. The issue is pretty annoying.

Thanks in advance.

[lomagdal2]

I'm no longer with the Notification Hubs team. I'll forward this to the right people so that it's on their radar.

…

-Louis

________________________________ From: Miłosz Kowalski ***@***.***> Sent: Wednesday, November 5, 2025 6:41 AM To: Azure/azure-notificationhubs-dotnet ***@***.***> Cc: Louis Magdaleno ***@***.***>; Mention ***@***.***> Subject: Re: [Azure/azure-notificationhubs-dotnet] Feature/fcmv1 (PR #311) [https://avatars.githubusercontent.com/u/29763140?s=20&v=4]MiloszKowalski left a comment (Azure/azure-notificationhubs-dotnet#311)<#311 (comment)> @lomagdal2<https://github.com/lomagdal2>, @rextor92<https://github.com/rextor92> Could you please merge this PR? It's been a while since it's been created and it already has an approve. The issue is pretty annoying. Thanks in advance. — Reply to this email directly, view it on GitHub<#311 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/BDPGQSS3QFSAHMSW5YQ2NN333IEBXAVCNFSM6AAAAACLHCHEFWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTIOJRGU4TGMJUG4>. You are receiving this because you were mentioned.Message ID: ***@***.***>

[rextor92]

Ah... Had this open for some time, we had a workaround and I moved on. I agree this is still good to have in the SDK. I'll sync with main and review to bring the PR up to date before Monday, Nov 24th; but I am not with Microsoft - will need someone to collaborate with for a review, merge and publish.