Several minor telemetry fixes for ASB

src/common/commonutils/CommandUtils.c

@@ -122,7 +122,7 @@ int ExecuteCommand(void* context, const char* command, bool replaceEol, bool for
     if (workerPid < 0)
     {
         OsConfigLogError(log, "Cannot fork for command '%s', fork() failed with %d (%s)", command, errno, strerror(errno));
-        OSConfigTelemetryStatusTrace("fork", errno);
+        OSConfigTelemetryStatusTrace("Cannot fork for command", errno);
         close(pipefd[0]);
         close(pipefd[1]);
         return errno;
@@ -202,7 +202,7 @@ int ExecuteCommand(void* context, const char* command, bool replaceEol, bool for
             if ((timeoutSeconds > 0) && (currentTime - startTime >= timeoutSeconds))
             {
                 OsConfigLogError(log, "Timeout reading from pipe for command '%s', %d seconds", command, (int)(currentTime - startTime));
-                OSConfigTelemetryStatusTrace("timeoutSeconds", ETIME);
+                OSConfigTelemetryStatusTrace("Timeout reading from pipe for command", ETIME);
                 status = ETIME;
                 break;
             }

src/common/commonutils/ConfigUtils.c

@@ -411,7 +411,7 @@ int SetLoggingLevelPersistently(LoggingLevel level, OsConfigLogHandle log)
             else if ((false == DirectoryExists(configurationDirectory)) && (0 != (result = mkdir(configurationDirectory, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH))))
             {
                 OsConfigLogError(log, "SetLoggingLevelPersistently: failed to create directory '%s'for the configuration file (%d, %s)", configurationDirectory, errno, strerror(errno));
-                OSConfigTelemetryStatusTrace("mkdir", errno);
+                OSConfigTelemetryStatusTrace("Failed to create directory for the configuration file", errno);
                 result = result ? result : (errno ? errno : ENOENT);
             }
             else if (false == SavePayloadToFile(configurationFile, buffer, strlen(buffer), log))

src/common/commonutils/PackageUtils.c

@@ -247,7 +247,6 @@ int IsPackageInstalled(const char* packageName, OsConfigLogHandle log)
     if (NULL == g_installedPackagesCache)
     {
         OsConfigLogError(log, "IsPackageInstalled: cannot check for '%s' presence without cache", packageName);
-        OSConfigTelemetryStatusTrace("g_installedPackagesCache", ENOENT);
         status = ENOENT;
     }
     else if (0 == status)

src/common/commonutils/PerfUtils.c

@@ -10,7 +10,6 @@ int StartPerfClock(PerfClock* clock, OsConfigLogHandle log)
     if (NULL == clock)
     {
         OsConfigLogError(log, "StartPerfClock called with an clock invalid argument");
-        OSConfigTelemetryStatusTrace("clock", EINVAL);
         return status;
     }
 
@@ -19,7 +18,6 @@ int StartPerfClock(PerfClock* clock, OsConfigLogHandle log)
     if (0 != (status = clock_gettime(CLOCK_MONOTONIC, &(clock->start))))
     {
         OsConfigLogError(log, "StartPerfClock: clock_gettime failed with %d (%d)", status, errno);
-        OSConfigTelemetryStatusTrace("clock_gettime", errno);
     }
 
     return status;
@@ -32,7 +30,6 @@ int StopPerfClock(PerfClock* clock, OsConfigLogHandle log)
     if (NULL == clock)
     {
         OsConfigLogError(log, "StopPerfClock called with an invalid clock argument");
-        OSConfigTelemetryStatusTrace("clock", EINVAL);
         return status;
     }
 
@@ -42,7 +39,6 @@ int StopPerfClock(PerfClock* clock, OsConfigLogHandle log)
         {
             OsConfigLogError(log, "StopPerfClock: clock_gettime returned an earlier time than expected (%ld seconds earlier)",
                 clock->start.tv_sec - clock->stop.tv_sec);
-            OSConfigTelemetryStatusTrace("clock_gettime", ENOENT);
 
             memset(clock, 0, sizeof(PerfClock));
 
@@ -52,7 +48,6 @@ int StopPerfClock(PerfClock* clock, OsConfigLogHandle log)
     else
     {
         OsConfigLogError(log, "StopPerfClock: clock_gettime failed with %d (%d)", status, errno);
-        OSConfigTelemetryStatusTrace("clock_gettime", errno);
     }
 
     return status;
@@ -67,7 +62,6 @@ long GetPerfClockTime(PerfClock* clock, OsConfigLogHandle log)
     if ((NULL == clock) || (0 == clock->stop.tv_sec))
     {
         OsConfigLogError(log, "GetPerfClockTime called with an invalid clock argument");
-        OSConfigTelemetryStatusTrace("clock", EINVAL);
         return microseconds;
     }
 
@@ -92,7 +86,6 @@ void LogPerfClock(PerfClock* clock, const char* componentName, const char* objec
     if ((NULL == clock) || (NULL == componentName))
     {
         OsConfigLogError(log, "LogPerfClock called with an invalid argument");
-        OSConfigTelemetryStatusTrace("clock", EINVAL);
         return;
     }
 

src/common/commonutils/UserUtils.c

@@ -481,7 +481,6 @@ int EnumerateUserGroups(SimplifiedUser* user, SimplifiedGroup** groupList, unsig
     else if (NULL == user->username)
     {
         OsConfigLogError(log, "EnumerateUserGroups: unable to enumerate groups for user without name");
-        OSConfigTelemetryStatusTrace("username", ENOENT);
         return ENOENT;
     }