Conversation
Test Results 64 files 64 suites 1h 5m 29s ⏱️ Results for commit 3ba9c19. ♻️ This comment has been updated with latest results. |
kkanas
changed the title
[], add Journal.Compess=yes as default[], add passOnNotFound to allow default parameter query
kkanas
force-pushed
the
kkanas/fix-systemdparameter-arg-block
branch
from
a6bd4a1 to
d5523b1
Compare
… be Compliant if value is not found Previously block param had to be in `[]` e.g. `[Journal]` to be working. Now block=Journal will query ini block `[Journal]` Use case is that systemd-analyze cat-config (and wider systemd) don't provide API to get default values. Using parameter passOnNotFound User can asure that default config is fine, unless overridden with not passing value. Signed-off-by: Krzysztof Kanas <kkanas@microsoft.com>
kkanas
force-pushed
the
kkanas/fix-systemdparameter-arg-block
branch
from
d5523b1 to
81aaee7
Compare
kkanas
changed the title
[], add passOnNotFound to allow default parameter query[], add passOnNotFound to make audit succeed if no value is found
danielszot
left a comment
danielszot
left a comment
There was a problem hiding this comment.
Would be best to add also at least one test for params.passOnNotFound = false set explicitly to catch when the default value will be changed (on purpose or by mistake).
I believe that the current test are sufficient to test value of passOnNotFound, there are that test for missing values and giving Compliant/Non Compliant. There are test that Check if value is there and flag passOnNotFound. |
3 participants
Description
SystemdParameter: block parameter do not need
[], add passOnNotFound to make audit succeed if no value is found (aka default is ok but we have no way of checking it)Describe your changes in as much detail as possible. Provide a link/reference to the issue solved with this request if any.
Checklist
devbranch prior to this PR submission.devbranch.