Skip to content

AuditEnsureAccountsWithoutShellAreLockedParams: add additional optional parameter to exclude users with not valid shells#1260

Merged
kkanas merged 5 commits intodevfrom
kkanas/EnsureAccountWithoutShells-params-skip-invalid-shells-v0
Mar 24, 2026
Merged

AuditEnsureAccountsWithoutShellAreLockedParams: add additional optional parameter to exclude users with not valid shells#1260
kkanas merged 5 commits intodevfrom
kkanas/EnsureAccountWithoutShells-params-skip-invalid-shells-v0

Conversation

@kkanas
Copy link
Copy Markdown
Contributor

@kkanas kkanas commented Mar 20, 2026

Description

AuditEnsureAccountsWithoutShellAreLockedParams: add additional optional parameter to exclude users with not valid shells

Azure Linux3 in addition to excluding UID_MIN also excludes users with not valid shell from failing compliance

Checklist

  • I have read the contribution guidelines.
  • I added unit-tests to validate my changes. All unit tests are passing.
  • I have merged the latest dev branch prior to this PR submission.
  • I ran pre-commit on my changes prior to this PR submission.
  • I submitted this PR against the dev branch.

…al parameter to exclude users with not valid shells

Signed-off-by: Krzysztof Kanas <kkanas@microsoft.com>
@kkanas kkanas requested review from a team as code owners March 20, 2026 10:21
kkanas and others added 3 commits March 20, 2026 11:28
…WithoutShellAreLocked.h

Co-authored-by: Robert Wojciechowski <robertwoj@microsoft.com>
…WithoutShellAreLocked.cpp

Co-authored-by: Robert Wojciechowski <robertwoj@microsoft.com>
Signed-off-by: Krzysztof Kanas <kkanas@microsoft.com>
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 20, 2026

Test Results

 64 files  ±0   64 suites  ±0   1h 3m 52s ⏱️ - 1m 3s
  8 tests ±0    8 ✅ ±0   0 💤 ±0  0 ❌ ±0 
256 runs  ±0  234 ✅ ±0  22 💤 ±0  0 ❌ ±0 

Results for commit be8db68. ± Comparison against base commit 9142cfa.

♻️ This comment has been updated with latest results.

Signed-off-by: Krzysztof Kanas <kkanas@microsoft.com>
@kkanas kkanas merged commit 70cf37a into dev Mar 24, 2026
142 of 144 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants