Skip to content

Fix for builds ./devops/scripts/run-module-tests.sh#1261

Merged
kkanas merged 4 commits intodevfrom
kkanas/fix-run-module-tests
Mar 26, 2026
Merged

Fix for builds ./devops/scripts/run-module-tests.sh#1261
kkanas merged 4 commits intodevfrom
kkanas/fix-run-module-tests

Conversation

@kkanas
Copy link
Copy Markdown
Contributor

@kkanas kkanas commented Mar 20, 2026

Description

Due recent changes run-module-tests.sh was not able to build containers localy.
Fix it by:

  • aligning run-module-tests.sh and .github/workflows/build-containers.yml
  • changed Heredoc RUN cat as it don't work with podman to printf
  • change script run-module-tests.sh to stop on error
  • removed custom context from containers aka --dockerfiledir
  • Use .dockeringnore to limit amount of data copied into src

Checklist

  • I have read the contribution guidelines.
  • I added unit-tests to validate my changes. All unit tests are passing.
  • I have merged the latest dev branch prior to this PR submission.
  • I ran pre-commit on my changes prior to this PR submission.
  • I submitted this PR against the dev branch.

Signed-off-by: Krzysztof Kanas <kkanas@microsoft.com>
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 20, 2026

Test Results

 37 files  +   36   37 suites   - 26   25m 51s ⏱️ + 24m 33s
  4 tests  - 1 087    4 ✅  - 1 087   0 💤 ± 0  0 ❌ ±0 
148 runs   -   943  127 ✅  -   964  21 💤 +21  0 ❌ ±0 

Results for commit 9263a97. ± Comparison against base commit d3faa6a.

This pull request removes 1091 and adds 4 tests. Note that renamed tests count towards both.
AuditdRulesCheckTest ‑ AuditctlCommandFails
AuditdRulesCheckTest ‑ ExcludeOptionsSkipsMatchingRules
AuditdRulesCheckTest ‑ ImmutableRuleCompliant
AuditdRulesCheckTest ‑ ImmutableRuleMissingIsNonCompliant
AuditdRulesCheckTest ‑ InvalidExcludeOptionsRegexReturnsError
AuditdRulesCheckTest ‑ InvalidOverridePathReturnsNonCompliant
AuditdRulesCheckTest ‑ InvalidRequiredOptionsRegexReturnsError
AuditdRulesCheckTest ‑ MultiSyscallOneMissingInFilesIsNonCompliant
AuditdRulesCheckTest ‑ OverridePathMissingFileRuleIsNonCompliant
AuditdRulesCheckTest ‑ OverridePathWithMatchingFileRuleIsCompliant
…
/mnt/vss/_work/azure-osconfig/azure-osconfig/src/tests/universal-nrp-e2e/UniversalNRP.Tests.ps1 ‑ Validate Universal NRP.Get.Ensure all resource instances have status
/mnt/vss/_work/azure-osconfig/azure-osconfig/src/tests/universal-nrp-e2e/UniversalNRP.Tests.ps1 ‑ Validate Universal NRP.Get.Ensure reasons are properly populated
/mnt/vss/_work/azure-osconfig/azure-osconfig/src/tests/universal-nrp-e2e/UniversalNRP.Tests.ps1 ‑ Validate Universal NRP.Get.Ensure the total resource instances count
/mnt/vss/_work/azure-osconfig/azure-osconfig/src/tests/universal-nrp-e2e/UniversalNRP.Tests.ps1 ‑ Validate Universal NRP.Set.Perform remediation

♻️ This comment has been updated with latest results.

…th from source tree

Remove Heredoc as it don't work with podman,
fix script run-module-tests.sh to use Dockeerfiles and stop on error

Signed-off-by: Krzysztof Kanas <kkanas@microsoft.com>
@kkanas kkanas marked this pull request as ready for review March 24, 2026 12:26
@kkanas kkanas requested review from a team as code owners March 24, 2026 12:26
@kkanas kkanas changed the title Initall fix for builds ./devops/scripts/run-module-tests.sh Fix for builds ./devops/scripts/run-module-tests.sh Mar 24, 2026
Copy link
Copy Markdown
Contributor

@MariusNi MariusNi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@kkanas kkanas enabled auto-merge (squash) March 25, 2026 14:48
@kkanas kkanas merged commit dd77294 into dev Mar 26, 2026
271 of 296 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants