PR Feedback

PR Feedback

Author: paterasMSFT

src/Batch/Batch.Test/ComputeNodeExtensions/GetBatchComputeNodeExtensionCommandTests.cs

@@ -61,7 +61,7 @@ public void GetBatchComputeNodeExtensionTest()
             cmdlet.BatchContext = context;
             cmdlet.PoolId = "testPool";
             cmdlet.ComputeNodeId = "testComputeNode";
-            cmdlet.ExtensionName = extensionName;
+            cmdlet.Name = extensionName;
 
             VMExtension extension = new VMExtension(extensionName, publisher, type);
 
@@ -102,7 +102,7 @@ public void GetBatchComputeNodeExtensionODataTest()
             cmdlet.BatchContext = context;
             cmdlet.PoolId = "testPool";
             cmdlet.ComputeNodeId = "testComputeNode";
-            cmdlet.ExtensionName = extensionName;
+            cmdlet.Name = extensionName;
             cmdlet.Select = "ExtensionName,Publisher";
 
             VMExtension extension = new VMExtension(extensionName, publisher, type);

src/Batch/Batch/ComputeNodeExtensions/GetBatchComputeNodeExtensionCommand.cs

@@ -42,7 +42,7 @@ public class GetBatchComputeNodeExtensionCommand : BatchObjectModelCmdletBase
         [Parameter(Position = 2, ParameterSetName = Constants.IdParameterSet, ValueFromPipelineByPropertyName = true, HelpMessage = "The name of the extension to get.")]
         [Parameter(Position = 2, ParameterSetName = Constants.ParentObjectParameterSet, ValueFromPipelineByPropertyName = true)]
         [ValidateNotNullOrEmpty]
-        public string ExtensionName { get; set; }
+        public string Name { get; set; }
 
         [Parameter(ParameterSetName = Constants.IdParameterSet)]
         [Parameter(ParameterSetName = Constants.ParentObjectParameterSet)]
@@ -61,7 +61,7 @@ public int MaxCount
 
         protected override void ExecuteCmdletImpl()
         {
-            ListComputeNodeExtensionParameters options = new ListComputeNodeExtensionParameters(BatchContext, PoolId, Pool, ComputeNodeId, ExtensionName, AdditionalBehaviors)
+            ListComputeNodeExtensionParameters options = new ListComputeNodeExtensionParameters(BatchContext, PoolId, Pool, ComputeNodeId, Name, AdditionalBehaviors)
             {
                 Select = Select,
                 MaxCount = MaxCount,

src/Batch/Batch/Pools/NewBatchPoolCommand.cs

@@ -70,7 +70,7 @@ public class NewBatchPoolCommand : BatchObjectModelCmdletBase
 
         [Parameter]
         [ValidateNotNullOrEmpty]
-        [GenericBreakingChange("MaxTasksPerComputeNode alias will be removed in an upcoming breaking change release", "4.2.0")]
+        [CmdletParameterBreakingChange("MaxTasksPerComputeNode", "MaxTasksPerComputeNode alias will be removed in an upcoming breaking change release.")]
         [Alias("MaxTasksPerComputeNode")]
         public int? TaskSlotsPerNode { get; set; }
 

src/Batch/Batch/Tasks/GetBatchTaskSlotCountCommand.cs

@@ -23,12 +23,22 @@ namespace Microsoft.Azure.Commands.Batch
     [Cmdlet("Get", ResourceManager.Common.AzureRMConstants.AzurePrefix + "BatchTaskSlotCount", DefaultParameterSetName = Constants.IdParameterSet), OutputType(typeof(PSTaskSlotCounts))]
     public class GetBatchTaskSlotCountCommand : BatchObjectModelCmdletBase
     {
-        [Parameter(Position = 0, ParameterSetName = Constants.IdParameterSet, Mandatory = true,
-            ValueFromPipelineByPropertyName = true, HelpMessage = "The id of the job for which to get task slot counts.")]
+        [Parameter(
+            Position = 0,
+            ParameterSetName = Constants.IdParameterSet,
+            Mandatory = true,
+            ValueFromPipelineByPropertyName = true,
+            HelpMessage = "The id of the job for which to get task slot counts."
+        )]
         [ValidateNotNullOrEmpty]
         public string JobId { get; set; }
 
-        [Parameter(Position = 0, ParameterSetName = Constants.ParentObjectParameterSet, ValueFromPipeline = true)]
+        [Parameter(
+            Position = 0, 
+            ParameterSetName = Constants.ParentObjectParameterSet,
+            ValueFromPipeline = true,
+            HelpMessage = "Specifies the job that contains tasks that this cmdlet gets. To obtain a **PSCloudJob** object, use the Get-AzBatchJob cmdlet."
+        )]
         [ValidateNotNullOrEmpty]
         public PSCloudJob Job { get; set; }
 

src/Batch/Batch/help/Get-AzBatchComputeNodeExtension.md

@@ -14,14 +14,14 @@ Gets Batch compute node extensions from a compute node.
 
 ### Id (Default)
 ```
-Get-AzBatchComputeNodeExtension [-PoolId] <String> [-ComputeNodeId] <String> [[-ExtensionName] <String>]
+Get-AzBatchComputeNodeExtension [-PoolId] <String> [-ComputeNodeId] <String> [[-Name] <String>]
  [-Select <String>] [-MaxCount <Int32>] -BatchContext <BatchAccountContext>
  [-DefaultProfile <IAzureContextContainer>] [<CommonParameters>]
 ```
 
 ### ParentObject
 ```
-Get-AzBatchComputeNodeExtension [-Pool] <PSCloudPool> [-ComputeNodeId] <String> [[-ExtensionName] <String>]
+Get-AzBatchComputeNodeExtension [-Pool] <PSCloudPool> [-ComputeNodeId] <String> [[-Name] <String>]
  [-Select <String>] [-MaxCount <Int32>] -BatchContext <BatchAccountContext>
  [-DefaultProfile <IAzureContextContainer>] [<CommonParameters>]
 ```
@@ -102,33 +102,33 @@ Accept pipeline input: False
 Accept wildcard characters: False
 ```
 
-### -ExtensionName
-The name of the extension to get.
+### -MaxCount
+Specifies the maximum number of compute node extensions to return.
 
 ```yaml
-Type: System.String
+Type: System.Int32
 Parameter Sets: (All)
 Aliases:
 
 Required: False
-Position: 2
+Position: Named
 Default value: None
-Accept pipeline input: True (ByPropertyName)
+Accept pipeline input: False
 Accept wildcard characters: False
 ```
 
-### -MaxCount
-{{ Fill MaxCount Description }}
+### -Name
+The name of the extension to get.
 
 ```yaml
-Type: System.Int32
+Type: System.String
 Parameter Sets: (All)
 Aliases:
 
 Required: False
-Position: Named
+Position: 2
 Default value: None
-Accept pipeline input: False
+Accept pipeline input: True (ByPropertyName)
 Accept wildcard characters: False
 ```
 
@@ -163,7 +163,8 @@ Accept wildcard characters: False
 ```
 
 ### -Select
-{{ Fill Select Description }}
+Specifies an OData select clause.
+Specify a value for this parameter to get specific properties rather than all object properties.
 
 ```yaml
 Type: System.String

src/Batch/Batch/help/Get-AzBatchTaskSlotCount.md

@@ -82,8 +82,7 @@ Accept wildcard characters: False
 ```
 
 ### -Job
-Specifies the job that contains tasks that this cmdlet gets.
-To obtain a **PSCloudJob** object, use the Get-AzBatchJob cmdlet.
+Specifies the job that contains tasks that this cmdlet gets. To obtain a **PSCloudJob** object, use the Get-AzBatchJob cmdlet.
 
 ```yaml
 Type: Microsoft.Azure.Commands.Batch.Models.PSCloudJob

src/Batch/Batch/help/New-AzBatchPool.md

@@ -416,7 +416,8 @@ Accept wildcard characters: False
 ```
 
 ### -TaskSlotsPerNode
-{{ Fill TaskSlotsPerNode Description }}
+The number of task slots that can be used to run concurrent tasks on a single compute node in the pool.
+The default value is 1. The maximum value is the smaller of 4 times the number of cores of the vmSize of the pool or 256.
 
 ```yaml
 Type: System.Nullable`1[System.Int32]