Fix Sql scenario test random failure issue (#23207)

* Fix Sql scenario test random failure issue

* Add instruction for re-recording ElasticJobPrivateEndpoint test cases

Author: vidai-msft

src/Sql/Sql.Test/ScenarioTests/DistributedAvailabilityGroupTests.ps1

@@ -58,6 +58,7 @@ function Test-ManagedInstanceLink
         Assert-Null $listLinksZero
 
         $upsertJ = New-AzSqlInstanceLink -ResourceGroupName $rgName -InstanceName $miName -LinkName $linkName -PrimaryAvailabilityGroupName $primaryAGName -SecondaryAvailabilityGroupName $secondaryAGName -TargetDatabase $targetDatabase -SourceEndpoint $sourceEndpoint -AsJob
+        $upsertJ | Wait-Job
 
         # wait a little bit for the link resource to be created
         Wait-Seconds 60
@@ -218,6 +219,7 @@ function Test-ManagedInstanceLinkErrHandling
 
         # upsert via CreateByParentObjectParameterSet
         $upsertJ = New-AzSqlInstanceLink -InstanceObject $instance -LinkName $linkName -PrimaryAvailabilityGroupName $primaryAGName -SecondaryAvailabilityGroupName $secondaryAGName -TargetDatabase $targetDatabase -SourceEndpoint $sourceEndpoint -AsJob
+        $upsertJ | Wait-Job
 
         # wait a little bit for the link resource to be created
         Wait-Seconds 60
@@ -300,7 +302,8 @@ function Test-ManagedInstanceLinkPiping
 
         # Upsert and get with parent instance Piping
         $upsertJ = $instance | New-AzSqlInstanceLink -LinkName $linkNamePipe -PrimaryAvailabilityGroupName $primaryAGNamePipe -SecondaryAvailabilityGroupName $secondaryAGNamePipe -TargetDatabase $targetDatabasePipe -SourceEndpoint $sourceEndpointPipe -AsJob
-        
+        $upsertJ | Wait-Job
+
         # wait a little bit for the link resource to be created
         Wait-Seconds 60
         $listResp = $instance | Get-AzSqlInstanceLink

src/Sql/Sql.Test/ScenarioTests/ElasticJobPrivateEndpointCrudTests.ps1

@@ -24,10 +24,12 @@ function Test-CreateJobPrivateEndpoint
 	{
 		$peName = Get-JobPrivateEndpointName 
 		$s1 = Get-AzSqlServer -ResourceGroupName $a1.ResourceGroupName -ServerName $a1.ServerName
+		# Be aware, to successfully re-record this test you will have to go approve the private endpoint in the server's Networking blade. Otherwise, it will not complete or will timeout.
 		$pe1AsJob = New-AzSqlElasticJobPrivateEndpoint -ElasticJobAgentObject $a1 -Name $peName -TargetServerAzureResourceId $s1.ResourceId -AsJob
+		$pe1AsJob | Wait-Job
 
 		# Give the backend a chance to persist the private endpoint before running Get
-		Start-Sleep 10
+		Start-TestSleep 10
 
 		$pe1 = Get-AzSqlElasticJobPrivateEndpoint -ElasticJobAgentObject $a1 -Name $peName
 
@@ -62,10 +64,12 @@ function Test-GetJobPrivateEndpoint
 	{
 		$peName = Get-JobPrivateEndpointName 
 		$s1 = Get-AzSqlServer -ResourceGroupName $a1.ResourceGroupName -ServerName $a1.ServerName
+		# Be aware, to successfully re-record this test you will have to go approve the private endpoint in the server's Networking blade. Otherwise, it will not complete or will timeout.
 		$pe1AsJob = New-AzSqlElasticJobPrivateEndpoint -ElasticJobAgentObject $a1 -Name $peName -TargetServerAzureResourceId $s1.ResourceId -AsJob
+		$pe1AsJob | Wait-Job
 
 		# Give the backend a chance to persist the private endpoint before running Get
-		Start-Sleep 10
+		Start-TestSleep 10
 
 		# Validate with Default set
 		$pe1 = Get-AzSqlElasticJobPrivateEndpoint -ResourceGroupName $a1.ResourceGroupName -ServerName $a1.ServerName -AgentName $a1.AgentName -Name $peName
@@ -134,10 +138,12 @@ function Test-RemoveJobPrivateEndpoint
 	{
 		$peName = Get-JobPrivateEndpointName 
 		$s1 = Get-AzSqlServer -ResourceGroupName $a1.ResourceGroupName -ServerName $a1.ServerName
+		# Be aware, to successfully re-record this test you will have to go approve the private endpoint in the server's Networking blade. Otherwise, it will not complete or will timeout.
 		$pe1AsJob = New-AzSqlElasticJobPrivateEndpoint -ElasticJobAgentObject $a1 -Name $peName -TargetServerAzureResourceId $s1.ResourceId -AsJob
+		$pe1AsJob | Wait-Job
 
 		# Give the backend a chance to persist the private endpoint before running Get
-		Start-Sleep 10
+		Start-TestSleep 10
 
 		$pe1 = Get-AzSqlElasticJobPrivateEndpoint -ElasticJobAgentObject $a1 -Name $peName