NIC renaming changes for TFO/FO #12207
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Can one of the admins verify this patch? |
|
|
punit-bhatt
suggested changes
Jun 18, 2020
Contributor
punit-bhatt
left a comment
punit-bhatt
left a comment
There was a problem hiding this comment.
- Cmdlet changes expected
- Markdown changes expected
- Design review expected
- Null handling
...teRecovery/ReplicationProtectedItem/SetAzureRmRecoveryServicesAsrReplicationProtectedItem.cs
Show resolved
Hide resolved
subashchandra31
changed the title
punit-bhatt
suggested changes
Jun 22, 2020
Contributor
punit-bhatt
left a comment
punit-bhatt
left a comment
There was a problem hiding this comment.
- Markdown changes expected
- Design review expected
- Update ChangeLog
...overyServices/RecoveryServices.SiteRecovery/NetworkInterfaceCard/NewAzureRmAsrVmNicConfig.cs
Show resolved
Hide resolved
...teRecovery/ReplicationProtectedItem/SetAzureRmRecoveryServicesAsrReplicationProtectedItem.cs
Show resolved
Hide resolved
Contributor
Author
|
Cmdlet design review : Approved https://github.com/Azure/azure-powershell-cmdlet-review-pr/issues/648 |
VeryEarly
previously approved these changes
Jun 29, 2020
Collaborator
|
Hi @subashchandra31 , Please resolve the merge conflicts. |
Contributor
Author
|
@VeryEarly handled merge conflicts.. |
VeryEarly
previously approved these changes
Jun 29, 2020
punit-bhatt
reviewed
Jun 29, 2020
src/RecoveryServices/RecoveryServices.SiteRecovery.Test/ScenarioTests/A2A/AsrA2ATests.ps1
Outdated
Show resolved
Hide resolved
punit-bhatt
reviewed
Jun 29, 2020
src/RecoveryServices/RecoveryServices.SiteRecovery.Test/ScenarioTests/A2A/AsrA2ATests.ps1
Outdated
Show resolved
Hide resolved
punit-bhatt
approved these changes
Jun 29, 2020
Contributor
Author
|
@VeryEarly can u plz approve nd merge PR.. |
VeryEarly
approved these changes
Jun 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist
CONTRIBUTING.mdChangeLog.mdfile(s) has been updated:ChangeLog.mdfile can be found atsrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md## Upcoming Releaseheader -- no new version header should be added