Skip to content

Multitenant Support #12292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
msJinLei merged 3 commits into from
Jul 27, 2020
Merged

Multitenant Support #12292

msJinLei merged 3 commits into from
Jul 27, 2020

Conversation

@msJinLei
Copy link
Contributor

@msJinLei msJinLei commented Jun 30, 2020 •
edited
Loading

Description

  • Upgrade the reference of SubscriptionClient from 2016-06-01 to 2019-06-01 in Az.Account
  • Display new subscription and tenant information in Get-AzTenant and Get-AzSubscription and handle multi-tenant in Connect-AzAccount and Set-AzContext
  • Implement fallback logic from SubscriptionClient from 2016-06-01 to 2019-06-01 to support Azure Stack

Related Issues

#7061
#9838
#10695
#11902

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
    • the markdown help files have been regenerated using the commands listed here

@adxsdkps
Copy link
Collaborator

adxsdkps commented Jun 30, 2020

Can one of the admins verify this patch?

@msJinLei msJinLei force-pushed the upgrade_sub branch 2 times, most recently from 921cfad to 76e26fb Compare July 1, 2020 05:14
@VeryEarly VeryEarly self-assigned this Jul 1, 2020
@msJinLei msJinLei force-pushed the upgrade_sub branch 9 times, most recently from 2c23e17 to 520a855 Compare July 3, 2020 04:51
@msJinLei msJinLei changed the title Multitenant support Multitenant Support in generation environment and AzureStack Jul 3, 2020
@msJinLei msJinLei marked this pull request as ready for review July 3, 2020 10:08
@msJinLei msJinLei changed the title Multitenant Support in generation environment and AzureStack Multitenant Support in general environment and AzureStack Jul 3, 2020
@msJinLei msJinLei requested review from erich-wang and isra-fel July 6, 2020 06:06
@erich-wang erich-wang added this to the S173 (2020-08-04) milestone Jul 6, 2020
@erich-wang
Copy link
Member

erich-wang commented Jul 6, 2020

Added Do Not Merge as it is targeting to 08-04 release

isra-fel
isra-fel reviewed Jul 7, 2020
View reviewed changes
@msJinLei msJinLei force-pushed the upgrade_sub branch 2 times, most recently from f2ee5f7 to ff1cd00 Compare July 13, 2020 02:22
dingmeng-xue
dingmeng-xue reviewed Jul 15, 2020
View reviewed changes
dingmeng-xue
dingmeng-xue reviewed Jul 15, 2020
View reviewed changes
@msJinLei msJinLei force-pushed the upgrade_sub branch 5 times, most recently from 1638f3a to 9033c90 Compare July 22, 2020 03:24
@msJinLei msJinLei changed the title Multitenant Support in general environment and AzureStack Multitenant Support Jul 22, 2020
@msJinLei msJinLei force-pushed the upgrade_sub branch 2 times, most recently from a63433b to 86410f5 Compare July 22, 2020 04:29
msJinLei added 2 commits July 22, 2020 12:37
Support Multitenant in Az.Accounts
1c88c52 
1. Upgrade the reference of SubscriptionClient from 2016-06-01 to
2019-06-01 in Az.Account
2. Display new subscription and tenant information in Get-AzTenant and
Get-AzSubscription and handle multi-tenant in Connect-AzAccount and
Set-AzContext
3. Implement fallback logic from SubscriptionClient from 2016-06-01 to
2019-06-01 to support Azure Stack

issues:
Azure#7061
Azure#9838
Azure#10695
Azure#11902
Address review comments
abedfd1
@msJinLei
Copy link
Contributor Author

msJinLei commented Jul 23, 2020

/azp run

@azure-pipelines
Copy link
Contributor

azure-pipelines bot commented Jul 23, 2020

Azure Pipelines successfully started running 3 pipeline(s).

isra-fel
isra-fel reviewed Jul 23, 2020
View reviewed changes
dingmeng-xue
dingmeng-xue requested changes Jul 23, 2020
View reviewed changes
erich-wang
erich-wang suggested changes Jul 23, 2020
View reviewed changes
dingmeng-xue
dingmeng-xue reviewed Jul 24, 2020
View reviewed changes
Address review comments
0cc80ca 
1. handling paging issue for list tenant
2. other miscellaneous issues
3. remove HomeTenantId and ManagedByTenantId from format table.
4. remove directory from PSTenant
@msJinLei msJinLei merged commit b71e423 into Azure:master Jul 27, 2020
This was referenced Jul 28, 2020
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@isra-fel isra-fel isra-fel left review comments

@dingmeng-xue dingmeng-xue dingmeng-xue approved these changes

+1 more reviewer

@erich-wang erich-wang erich-wang approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@VeryEarly VeryEarly

Labels

needs-review

Projects

None yet

Milestone

S173 (2020-08-04)

Development

Successfully merging this pull request may close these issues.

7 participants

@msJinLei @adxsdkps @erich-wang @isra-fel @dingmeng-xue @azuresdkci @VeryEarly