Skip to content

Conversation

@MoustafaEid
Copy link
Contributor

Description

This PR fixes an issue where an exception is being thrown when Enum.Parse tries to coerce a null value to an Enabled or Disabled enum values

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
    • the markdown help files have been regenerated using the commands listed here

@adxsdkps
Copy link
Collaborator

Can one of the admins verify this patch?

@MoustafaEid MoustafaEid changed the title [Frontdoor][Bug Fix] Nullable DynamicCompression fix [Frontdoor][Bug] Nullable DynamicCompression fix Jul 29, 2020
@MoustafaEid MoustafaEid linked an issue Jul 29, 2020 that may be closed by this pull request
@isra-fel isra-fel changed the base branch from master to release-2020-08-04 July 29, 2020 05:57
@isra-fel
Copy link
Member

Retargeting release branch.
@MoustafaEid please add an entry to changelog next time when fixing an issue or adding a new feature -- it will be in the release notes of your module and Az.
Thanks

Copy link
Member

@isra-fel isra-fel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@isra-fel isra-fel self-assigned this Jul 29, 2020
@isra-fel isra-fel added this to the S173 (2020-08-04) milestone Jul 29, 2020
@isra-fel isra-fel merged commit 3d76cb2 into Azure:release-2020-08-04 Jul 29, 2020
@MoustafaEid MoustafaEid deleted the fix-nullable-dynamic-compression branch July 29, 2020 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

New-AzFrontDoor failed in version 1.5.0

3 participants