Skip to content

[SignalR] Add Set-AzSignalRUpstream, Update-AzSignalRNetworkAcl commands #12583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
isra-fel merged 6 commits into from
Aug 10, 2020
Merged

[SignalR] Add Set-AzSignalRUpstream, Update-AzSignalRNetworkAcl commands #12583

isra-fel merged 6 commits into from
Aug 10, 2020

Conversation

@Y-Sindo
Copy link
Member

@Y-Sindo Y-Sindo commented Aug 6, 2020 •
edited
Loading

Description

  1. fix Restart-AzSignalR,Update-AzSignalR help files error
  2. Add Set-AzSignalRUpstream, Update-AzSignalRNetworkAcl commands

close Azure/azure-powershell-cmdlet-review-pr#690

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
    • the markdown help files have been regenerated using the commands listed here
  • If applicable, the changes made in the PR have proper test coverage

@Y-Sindo Y-Sindo closed this Aug 6, 2020
@Y-Sindo Y-Sindo reopened this Aug 6, 2020
@Y-Sindo Y-Sindo force-pushed the master branch 2 times, most recently from 00dee17 to f875e67 Compare August 6, 2020 07:47
@isra-fel isra-fel self-assigned this Aug 6, 2020
isra-fel
isra-fel requested changes Aug 10, 2020
View reviewed changes
Copy link
Member

@isra-fel isra-fel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally LGTM. Just a few issues:

@isra-fel isra-fel merged commit 3debb61 into Azure:master Aug 10, 2020
@Y-Sindo Y-Sindo added this to the S174 (2020-08-25) milestone Aug 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@isra-fel isra-fel isra-fel approved these changes

Assignees

@isra-fel isra-fel

@Y-Sindo Y-Sindo

Labels

needs-review

Projects

None yet

Milestone

S174 (2020-08-25)

Development

Successfully merging this pull request may close these issues.

2 participants

@Y-Sindo @isra-fel