Skip to content

Conversation

@dingmeng-xue
Copy link
Member

@dingmeng-xue dingmeng-xue commented Aug 6, 2020

Description

Update Microsoft.PowerShell.SDK to 6.2.4
Update Newtonsoft.Json to 12.0.3
Disable CI trigger in pipeline
Use ADO default component scan

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
    • the markdown help files have been regenerated using the commands listed here

@adxsdkps
Copy link
Collaborator

adxsdkps commented Aug 6, 2020

Can one of the admins verify this patch?

@isra-fel
Copy link
Member

isra-fel commented Aug 11, 2020

Conflicting assemblies

powershell-core (Analyze windows):

"Target","AssemblyName","AssemblyVersion","Severity","ProblemId","Description","Remediation"
  "File version 4.6 in D:\a\1\s\artifacts\Debug\Az.IotHub\System.Runtime.CompilerServices.Unsafe.dll, File version 0.0 in D:\a\1\s\artifacts\Debug\Az.Batch\System.Runtime.CompilerServices.Unsafe.dll","System.Runtime.CompilerServices.Unsafe","4.0.6.0","0","7000","Shared assembly conflict, shared assemblies with the same assembly version have differing file versions","Update the assembly reference for System.Runtime.CompilerServices.Unsafe in one of the referring assemblies"
  "File version 4.700 in D:\a\1\s\artifacts\Debug\Az.Storage\System.Runtime.CompilerServices.Unsafe.dll, File version 0.0 in D:\a\1\s\artifacts\Debug\Az.Batch\System.Runtime.CompilerServices.Unsafe.dll","System.Runtime.CompilerServices.Unsafe","4.0.6.0","0","7000","Shared assembly conflict, shared assemblies with the same assembly version have differing file versions","Update the assembly reference for System.Runtime.CompilerServices.Unsafe in one of the referring assemblies"
  "File version 4.700 in D:\a\1\s\artifacts\Debug\Az.Storage\System.Text.Encodings.Web.dll, File version 4.6 in D:\a\1\s\artifacts\Debug\Az.Batch\System.Text.Encodings.Web.dll","System.Text.Encodings.Web","4.0.5.0","0","7000","Shared assembly conflict, shared assemblies with the same assembly version have differing file versions","Update the assembly reference for System.Text.Encodings.Web in one of the referring assemblies"
  "File version 4.700 in D:\a\1\s\artifacts\Debug\Az.Synapse\System.Runtime.CompilerServices.Unsafe.dll, File version 0.0 in D:\a\1\s\artifacts\Debug\Az.Batch\System.Runtime.CompilerServices.Unsafe.dll","System.Runtime.CompilerServices.Unsafe","4.0.6.0","0","7000","Shared assembly conflict, shared assemblies with the same assembly version have differing file versions","Update the assembly reference for System.Runtime.CompilerServices.Unsafe in one of the referring assemblies"
  "File version 4.700 in D:\a\1\s\artifacts\Debug\Az.Synapse\System.Text.Encodings.Web.dll, File version 4.6 in D:\a\1\s\artifacts\Debug\Az.Batch\System.Text.Encodings.Web.dll","System.Text.Encodings.Web","4.0.5.0","0","7000","Shared assembly conflict, shared assemblies with the same assembly version have differing file versions","Update the assembly reference for System.Text.Encodings.Web in one of the referring assemblies"

windows-powershell (Analyze):

D:\a\1\s\artifacts//StaticAnalysisResults\SharedAssemblyConflict.csv:
  "Target","AssemblyName","AssemblyVersion","Severity","ProblemId","Description","Remediation"
  "File version 4.6 in D:\a\1\s\artifacts\Debug\Az.IotHub\System.Runtime.CompilerServices.Unsafe.dll, File version 0.0 in D:\a\1\s\artifacts\Debug\Az.Batch\System.Runtime.CompilerServices.Unsafe.dll","System.Runtime.CompilerServices.Unsafe","4.0.6.0","0","7000","Shared assembly conflict, shared assemblies with the same assembly version have differing file versions","Update the assembly reference for System.Runtime.CompilerServices.Unsafe in one of the referring assemblies"
  "File version 4.700 in D:\a\1\s\artifacts\Debug\Az.Storage\System.Runtime.CompilerServices.Unsafe.dll, File version 0.0 in D:\a\1\s\artifacts\Debug\Az.Batch\System.Runtime.CompilerServices.Unsafe.dll","System.Runtime.CompilerServices.Unsafe","4.0.6.0","0","7000","Shared assembly conflict, shared assemblies with the same assembly version have differing file versions","Update the assembly reference for System.Runtime.CompilerServices.Unsafe in one of the referring assemblies"
  "File version 4.700 in D:\a\1\s\artifacts\Debug\Az.Storage\System.Text.Encodings.Web.dll, File version 4.6 in D:\a\1\s\artifacts\Debug\Az.Batch\System.Text.Encodings.Web.dll","System.Text.Encodings.Web","4.0.5.0","0","7000","Shared assembly conflict, shared assemblies with the same assembly version have differing file versions","Update the assembly reference for System.Text.Encodings.Web in one of the referring assemblies"
  "File version 4.700 in D:\a\1\s\artifacts\Debug\Az.Synapse\System.Runtime.CompilerServices.Unsafe.dll, File version 0.0 in D:\a\1\s\artifacts\Debug\Az.Batch\System.Runtime.CompilerServices.Unsafe.dll","System.Runtime.CompilerServices.Unsafe","4.0.6.0","0","7000","Shared assembly conflict, shared assemblies with the same assembly version have differing file versions","Update the assembly reference for System.Runtime.CompilerServices.Unsafe in one of the referring assemblies"
  "File version 4.700 in D:\a\1\s\artifacts\Debug\Az.Synapse\System.Text.Encodings.Web.dll, File version 4.6 in D:\a\1\s\artifacts\Debug\Az.Batch\System.Text.Encodings.Web.dll","System.Text.Encodings.Web","4.0.5.0","0","7000","Shared assembly conflict, shared assemblies with the same assembly version have differing file versions","Update the assembly reference for System.Text.Encodings.Web in one of the referring assemblies"

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This reference needs also to be updated

Suggested change
<PackageReference Include="Newtonsoft.Json" Version="11.0.2" />
<PackageReference Include="Newtonsoft.Json" Version="12.0.3" />

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants