Skip to content

Use release binaries for bumping version #12624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dingmeng-xue merged 1 commit into from
Aug 11, 2020
Merged

Use release binaries for bumping version #12624

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions tools/RunVersionController.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,8 +219,8 @@ switch ($PSCmdlet.ParameterSetName)
$ModuleName = $JsonFile.Replace('Microsoft.Azure.PowerShell.Cmdlets.', '').Replace('.dll.json', '')
if (!$ExpectJsonHashSet.Contains($JsonFile))
{
Write-Host "Module ${ModuleName} is not GA yet. Remove the json file: ${JsonFile}." -ForegroundColor Red
rm $(Join-Path -Path "$PSScriptRoot\Tools.Common\SerializedCmdlets" -ChildPath $JsonFile)
Write-Warning "Module ${ModuleName} is not GA yet. The json file: ${JsonFile} is for reference"
# rm $(Join-Path -Path "$PSScriptRoot\Tools.Common\SerializedCmdlets" -ChildPath $JsonFile)
}
}
try
Expand Down
4 changes: 2 additions & 2 deletions tools/VersionController/Models/VersionFileHelper.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ public VersionFileHelper(string rootDirectory, string outputModuleManifestPath,
OutputModuleManifestPath = outputModuleManifestPath;
ProjectModuleManifestPath = projectModuleManifestPath;

_outputDirectories = new List<string>{ DebugDirectory };
_outputDirectories = new List<string>{ ReleaseDirectory };

_projectDirectories = new List<string>{ Path.Combine(RootDirectory, @"src") };
}
Expand All @@ -27,7 +27,7 @@ public VersionFileHelper(string rootDirectory, string outputModuleManifestPath,

public string PackageDirectory => Path.Combine(RootDirectory, @"artifacts");

public string DebugDirectory => Path.Combine(PackageDirectory, @"Debug");
public string ReleaseDirectory => Path.Combine(PackageDirectory, @"Release");

public string ArtifactsVersionControllerDirectory => Path.Combine(PackageDirectory, @"VersionController");

Expand Down
2 changes: 1 addition & 1 deletion tools/VersionController/Program.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ public static void Main(string[] args)

_rootDirectory = Directory.GetParent(artifactsDirectory).FullName;
_projectDirectories = new List<string>{ Path.Combine(_rootDirectory, @"src\") }.Where((d) => Directory.Exists(d)).ToList();
_outputDirectories = new List<string>{ Path.Combine(_rootDirectory, @"artifacts\Debug\") }.Where((d) => Directory.Exists(d)).ToList();
_outputDirectories = new List<string>{ Path.Combine(_rootDirectory, @"artifacts\Release\") }.Where((d) => Directory.Exists(d)).ToList();

var exceptionsDirectory = Path.Combine(AppDomain.CurrentDomain.BaseDirectory, "Exceptions");
if (args != null && args.Length > 0)
Expand Down