Skip to content

Add Get-AzVirtualRouterPeerAdvertisedRoute and Get-AzVirtualRouterPeerLearnedRoute cmdlets #13115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
litchiyangMSFT wants to merge 17 commits into from
Closed

Add Get-AzVirtualRouterPeerAdvertisedRoute and Get-AzVirtualRouterPeerLearnedRoute cmdlets #13115

litchiyangMSFT wants to merge 17 commits into from

Conversation

@litchiyangMSFT
Copy link
Contributor

@litchiyangMSFT litchiyangMSFT commented Sep 30, 2020 •
edited
Loading

Description

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
    • the markdown help files have been regenerated using the commands listed here

litchiyangMSFT and others added 15 commits August 19, 2020 22:47
@litchiyangMSFT
Add Get-AzVirtualRouterPeerAdvertisedRouter and Get-AzVirtualRouterPe…
9394bff 
…erLearnedRouter
@litchiyangMSFT
Update Get-AzVirtualRouterPeerAdvertisedRoute.md
a65494c
@litchiyangMSFT
Update Get-AzVirtualRouterPeerLearnedRoute.md
aa02766
@litchiyangMSFT
Fix bug in parameterset
1fc98ff
@litchiyangMSFT
Merge branch 'network-june' of https://github.com/litchiyangMSFT/azur…
22392f6 
…e-powershell into peerRoutes
@litchiyangMSFT
Change test name
3bbd377
@VeryEarly
Update ChangeLog.md
5d6af5d
@litchiyangMSFT
merge
f9197de
@litchiyangMSFT
Update Get-AzVirtualRouterPeerAdvertisedRoute.md
6bba557
@litchiyangMSFT
Update Get-AzVirtualRouterPeerLearnedRoute.md
428d309
@litchiyangMSFT
Merge branch 'network-june' of https://github.com/litchiyangMSFT/azur…
6c30cdb 
…e-powershell into peerRoutes
@litchiyangMSFT
Merge branch 'network-june' of https://github.com/Azure/azure-powershell
0fcce27 
 into peerRoutes
@litchiyangMSFT
Merge branch 'network-july' of https://github.com/Azure/azure-powershell
de93b81 
 into peerRoutes
@litchiyangMSFT
test
a43ea3f
@litchiyangMSFT
test
680d0cd
@isra-fel isra-fel self-assigned this Sep 30, 2020
isra-fel
isra-fel requested changes Oct 9, 2020
View reviewed changes
...ecords/Commands.Network.Test.ScenarioTests.VirtualRouterTests/TestVirtualRouterPeerCRUD.json Outdated
],
"Names": {
"Test-VirtualRouterPeerCRUD": [
"Test-HubBgpConnectionCRUD": [
Copy link
Member

@isra-fel isra-fel Oct 9, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems you modified the test case name in recordings but not source code, so the case is failing

[xUnit.net 00:08:19.35] Commands.Network.Test.ScenarioTests.VirtualRouterTests.TestVirtualRouterPeerCRUD [FAIL]

Copy link
Contributor Author

@litchiyangMSFT litchiyangMSFT Oct 9, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

resolved

@isra-fel
Copy link
Member

isra-fel commented Oct 9, 2020

/azp run

@azure-pipelines
Copy link
Contributor

azure-pipelines bot commented Oct 9, 2020

Azure Pipelines successfully started running 3 pipeline(s).

@isra-fel
Copy link
Member

isra-fel commented Oct 12, 2020

As we talked offline, network-july is not going into this milestone, so could you please change the base branch to master? Thanks

@isra-fel
Copy link
Member

isra-fel commented Oct 13, 2020

Close on behalf of #13196

@isra-fel isra-fel closed this Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@isra-fel isra-fel isra-fel approved these changes

@MikhailTryakhov MikhailTryakhov Awaiting requested review from MikhailTryakhov

Assignees

@isra-fel isra-fel

@litchiyangMSFT litchiyangMSFT

Labels

Do Not Merge 🚫 Waiting for CI :shipit:

Projects

None yet

Milestone

S177 (2020-10-27) Major Release

Development

Successfully merging this pull request may close these issues.

4 participants

@litchiyangMSFT @isra-fel @azuresdkci @VeryEarly