Skip to content

[Resources] Fixed an issue where deployment cmdlets does not preserve case of parameters #13222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
isra-fel merged 2 commits into from
Oct 15, 2020
Merged

[Resources] Fixed an issue where deployment cmdlets does not preserve case of parameters #13222

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a0df441
Should not use settings when serializing templates and paramaters
shenglol Oct 15, 2020
949458a
Update change log
shenglol Oct 15, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Resources/ResourceManager/Json/PSJsonSerializer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ public static string Serialize(object value, SerializeContext context)
{
object processed = ProcessValue(value, 0, context);

return JsonConvert.SerializeObject(processed, JsonExtensions.ObjectSerializationSettings);
return JsonConvert.SerializeObject(processed);
}
catch (OperationCanceledException)
{
Expand Down
4 changes: 2 additions & 2 deletions src/Resources/Resources.Test/Json/PSJsonSerializerTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ public void Serialize_Hashtable_Success()
var hashtable = new Hashtable
{
["foo"] = new PSObject("fooValue"),
["bar"] = true,
["Bar"] = true,
["nested"] = new Hashtable
{
["foo"] = new PSObject(Guid.Parse("4d44fe86-f04a-4ba5-9900-abdec8cb11c1")),
Expand Down Expand Up @@ -94,7 +94,7 @@ public void Serialize_Hashtable_Success()
JToken expected = JToken.FromObject(new
{
foo = "fooValue",
bar = true,
Bar = true,
nested = new
{
foo = "4d44fe86-f04a-4ba5-9900-abdec8cb11c1",
Expand Down
1 change: 1 addition & 0 deletions src/Resources/Resources/ChangeLog.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
## Upcoming Release
* Updated ARM template What-If cmdlets to remove preview message from results
* Fixed an issue where template deployment cmdlets crash if `-WhatIf` is set at a higher scope [#13038]
* Fixed an issue where template deployment cmdlets does not preserve case for template parameters
* Added a default API version to be used in `Export-AzResourceGroup` cmdlet
* Added cmdlets for Template Specs (`Get-AzTemplateSpec`, `Set-AzTemplateSpec`, `New-AzTemplateSpec`, `Remove-AzTemplateSpec`, `Export-AzTemplateSpec`)
* Added support for deploying Template Specs using existing deployment cmdlets (via the new -TemplateSpecId parameter)
Expand Down