-
Notifications
You must be signed in to change notification settings - Fork 4.1k
Allow Get-AzLogicAppRunHistory to return more than 30 entries #13393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 6 commits
beacc58
2448dd0
a5d14e8
f29de19
fb510ea
bead4d5
dc2f638
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -40,9 +40,16 @@ public void CancelWorkflowRun(string resourceGroupName, string workflowName, | |
| /// <param name="resourceGroupName">Name of the resource group</param> | ||
| /// <param name="workflowName">Name of the workflow</param> | ||
| /// <returns>List of workflow runs</returns> | ||
| public Page<WorkflowRun> GetWorkflowRuns(string resourceGroupName, string workflowName) | ||
| public Page<WorkflowRun> GetWorkflowRuns(string resourceGroupName, string workflowName, string nextPageLink = "") | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. nit: please use constant string.Empty
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Didn't think that was possible here.
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ah yes I forgot, it's not defined as a const but as a read-only static so we can't use it for default parameters.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Not a fan of empty quotes either |
||
| { | ||
| return (Page<WorkflowRun>)this.LogicManagementClient.WorkflowRuns.List(resourceGroupName, workflowName); | ||
| if (string.IsNullOrWhiteSpace(nextPageLink)) | ||
| { | ||
| return (Page<WorkflowRun>)this.LogicManagementClient.WorkflowRuns.List(resourceGroupName, workflowName); | ||
| } | ||
| else | ||
| { | ||
| return (Page<WorkflowRun>)this.LogicManagementClient.WorkflowRuns.ListNext(nextPageLink); | ||
| } | ||
mikejwhat marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| } | ||
|
|
||
| /// <summary> | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.