Skip to content

Conversation

azure-sdk
Copy link
Collaborator

@azure-sdk azure-sdk commented Dec 9, 2022

[Hub Generated] Review request for Microsoft.SqlVirtualMachine to add version preview/2022-08-01-preview (Azure#21422)

* Adds base for updating Microsoft.SqlVirtualMachine from version preview/2022-07-01-preview to version 2022-08-01-preview

* Updates readme

* Updates API version in new specs and examples

* Adding 2022-08-01-preview version for Sql Virtual Machine swagger

* move all api-version to 2022-08-01-preview

* fix the following validation errors:

R4041 - XmsIdentifierValidation
R4009 - RequiredReadOnlySystemData

* add location for 202 reponse

* fix typo

* fix LRO_RESPONSE_HEADER validation error

* fix Swagger PrettierCheck

* fix 1047 - XmsEnumChanged, manually move IdentityTypeWithNone to
IdentityType

* fix DefinitionsPropertiesNamesCamelCase, adding
azureADAuthenticationSettings to the custom-words.txt

* adding azureADAuthenticationSettings in the alphabetical position.

* fix PostOperationAsyncResponseValidation and  LroLocationHeader errors

* fix typo

* missing quote

* adding quote

* fix DefinitionsPropertiesNamesCamelCase

* remove azureADAuthenticationSettings

* fix ResourceNameRestriction

* use \" to escape "

* fix swagger regex syntax difference comparing to C# regex

* addressing one comment from ARM team to add error response schema for
the default response:

* fix 202 response:
1. adding Location header
2. adding specify x-ms-long-running-operation-options

* UnHealthyReplica to UnhealthyReplica
uuHealthyReplica to unhealthyReplica

* TroubleShoot to Troubleshoot
troubleShoot to troubleshoot

* "UTC format" to "UTC timezone"

* SqlVmTroubleshoot to SqlVmTroubleshooting

* Successfully started SQL virtual machine troubleshoot to Successfully
started SQL virtual machine troubleshooting and similar cases

* "SQL Iaas Extension" to "SQL IaaS Extension"

* Assessment to "an assessment" and other similiar issues

* resolve conflict for custom-words.txt

* resolve conflict

* adding default for troubleshootingScenario

* refactor all sqlVirtualMachineName into common definition and reference
it elsewhere

* add x-ms-long-running-operation-options with azure-async-operation

* remove Location header from the Post request

* add back the Location header for the Post method, as the validation
checks it

* add response schema to HA troubleshooting endpoint 200 response.

* add "default" to false for SQL IAAS auto upgrade property

* renaming:
troubleshootStatus => troubleshootingStatus
unhealthyReplicaProperties => unhealthyReplicaInfo

* update the HA troubleshooting example after the renaming in this
endpoint

* rewording Assessment as SQL best practices Assessment after consulting
with PM.

* revert custom-words.tx file

Co-authored-by: Qiang Liu <[email protected]>
@azure-sdk azure-sdk closed this Dec 9, 2022
@azure-sdk azure-sdk changed the title [ReleasePR Az.sqlvirtualmachine] [Hub Generated] Review request for Microsoft.SqlVirtualMachine to add version preview/2022-08-01-preview [ReleasePR Az.sqlvirtualmachine] {AzureSQLVM} fixes Azure/azure-rest-api-specs#22768 Fix the enums under AgReplica Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant