[ReleasePR Az.commerce] UsageV3 S360 Updates #21112
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UsageV3 S360 Updates (Azure#22637) * UsageV3 S360 Updates Corrected three items that were flagging for swagger compliance in S360. Added definitions for 202 responses and added 'error' as a property to definition for 'ErrorResponse'. * Removed 202 Response for Ratecard Removed the 202 response for Ratecard Ratecard is a different service that is not getting flagged for in S360 and does not support 202 response code. * Undo ErrorMessage Properties Swagger will not let ErrorResponse contain an error property with subproperties. Reverting ErrorResponse to contain "code" and "message" as its properties. * Ran Prettier Ran prettier in order to address Pull Request check. * Added xm-ms-long-running-operation Property Added xm-ms-long-running-operation Property to the UsageAggregates_List get call in order to justify the addition of the 202 response. * Added x-ms-long-running-operation-options Added x-ms-long-running-operation-options. Adding a 202 response requires that these options be set. * Prettier Run Reran prettier after the last commit to correct formatting issues. * Added x-ms-example for GetUsageAggregates_List Added x-ms-example for GetUsageAggregates_List. PR check was flagging because there was no example present. Will create the referenced json file in the next commit. * Added example file for UsageAggregates List There was previously no example for UsageAggregates List, but there was one for RateCard. The following documentation was used to generate this example file. https://learn.microsoft.com/en-us/previous-versions/azure/reference/mt219001(v=azure.100)?redirectedfrom=MSDN#sample-responses * Corrected Formatting for UsageAggregatesList Example Value Array was missing brackets for its element. * Corrected Example File Name Corrected the file name to exclude an underscore. * Added Location Header to 202 Response Added location header to the 202 response. * Corrected Location to use double quotes Corrected formatting issue with the previous commit that added a location header to the 202 response. * Updated Example Fields Updated infofields to match the example given in the api documentation. * Added 202 Response Added a 202 response to the example file. * GetUsageAggregatesList.json Prettier Update Reran Prettier script on GetUsageAggregatesList.json * Updated case 'Daily' and Example 202 Response Updated case 'Daily' and Example 202 Response. These changes were made previously, but lost at some point. * Removed Error from 202 Body Error property not allowed in the response. * Removed InfoFields properties. Removed all subproperties for InfoFields. Our api no longer returns any properties for InfoFields. * Removed Infofields properties. Removed Infofields properties. Our api no longer returns any of these properties in a 200 response. * Removed InfoFields Properties Removed Property from InfoFields. This should have been removed along with the other properties in the previous commit. * Removed LongRunning operation Removed longrunning operation from UsageAggregates_List. * Removed Location Header Location header no longer needed.
| Validation for PowerShell Core and Windows PowerShell Starts. Thanks for your contribution! |
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create to sync Azure/azure-rest-api-specs#22637
ReCreate this PR