[notification hubs] sdk migration to autorest powershell #26829
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
️✔️Az.Accounts
|
| Type | Cmdlet | Description | Remediation |
|---|---|---|---|
| AssemblyInfo.cs will be updated automatically. Please do not update it manually. | Revert AssemblyInfo.cs to its last version. |
⚠️ Windows PowerShell - Windows
| Type | Cmdlet | Description | Remediation |
|---|---|---|---|
| AssemblyInfo.cs will be updated automatically. Please do not update it manually. | Revert AssemblyInfo.cs to its last version. |
️✔️UX Metadata Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Generated Sdk Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
⚠️ Test
⚠️ - Linux
Type Title Current Coverage Description ⚠️ Test Coverage Less Than 50% 47.62 % Test coverage for the module cannot be lower than 50%.
⚠️ - MacOS
Type Title Current Coverage Description ⚠️ Test Coverage Less Than 50% 47.62% Test coverage for the module cannot be lower than 50%.
⚠️ PowerShell Core - Windows
Type Title Current Coverage Description ⚠️ Test Coverage Less Than 50% 47.62% Test coverage for the module cannot be lower than 50%.
⚠️ Windows PowerShell - Windows
Type Title Current Coverage Description ⚠️ Test Coverage Less Than 50% 47.62% Test coverage for the module cannot be lower than 50%.
…o joyer/NotificationHubs-sdk-migration
Contributor
|
Waiting for service team to test and confirm |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR migrates the NotificationHubs module from using a legacy NuGet package dependency to an autorest-generated PowerShell management SDK. The migration removes the external "Microsoft.Azure.Management.NotificationHubs" package dependency and replaces it with a locally generated SDK project.
- Replaces external NuGet package dependency with locally generated SDK project reference
- Updates property names to match the new SDK's API structure
- Reorganizes project structure to include the new autogenerated management SDK
Reviewed Changes
Copilot reviewed 8 out of 59 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| NotificationHubsManagementClient.cs | Updates property names from NotificationHubCreateOrUpdateParametersName to PropertiesName to match new SDK |
| NotificationHubs.csproj | Replaces NuGet package reference with project reference to new management SDK |
| ChangeLog.md | Documents the removal of the legacy package reference |
| Az.NotificationHubs.psd1 | Updates required assemblies to reference the new SDK DLL |
| NotificationHubs.sln | Adds new management SDK project and updates project references |
| README.md | New autorest configuration file for SDK generation |
| AssemblyInfo.cs | Assembly metadata for the new management SDK |
| NotificationHubs.Management.Sdk.csproj | Project file for the new autogenerated management SDK |
| using System.Runtime.CompilerServices; | ||
| using System.Runtime.InteropServices; | ||
|
|
||
| [assembly: AssemblyTitle("Microsoft Azure Powershell - NotificationHubs Management SDK")] |
There was a problem hiding this comment.
The word 'Powershell' should be 'PowerShell' with proper capitalization.
Suggested change
| [assembly: AssemblyTitle("Microsoft Azure Powershell - NotificationHubs Management SDK")] | |
| [assembly: AssemblyTitle("Microsoft Azure PowerShell - NotificationHubs Management SDK")] |
|
|
isra-fel
added
the
Track1 SDK Migration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Mandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.mdand reviewed the following information:ChangeLog.mdfile(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.## Upcoming Releaseheader in the past tense.ChangeLog.mdif no new release is required, such as fixing test case only.