[StackHCIVM] hcrp api version update #28237
Conversation
| Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status. |
There was a problem hiding this comment.
Pull Request Overview
This PR updates Azure Stack HCI VM test configuration and dependencies. It migrates test environment configurations to new Azure subscriptions/resource groups and updates API specifications to use a newer stable release.
- Updated test environment configurations with new subscription IDs, resource groups, and resource paths
- Enhanced test coverage by adding new VM state management tests (Save and Pause operations)
- Updated API specifications from preview version to stable release (2025-01-13)
Reviewed Changes
Copilot reviewed 8 out of 14 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| env.json / envVariables.json | Updated test environment with new Azure subscription, tenant, and resource identifiers |
| AzStackHCIVMVirtualMachine.Tests.ps1 | Added new test cases for VM save and pause operations with proper error handling |
| AzStackHCIVMStoragePath.Tests.ps1 | Updated to use environment variable for storage path instead of hardcoded value |
| AzStackHCIVMNetworkInterface.Tests.ps1 | Updated to use environment variable for subnet ID instead of hardcoded value |
| AzStackHCIVMImageNew.Tests.ps1 | Fixed test formatting and updated to use dynamic resource IDs from environment |
| New-AzStackHCIVMImage.ps1 | Added test playback detection, secure string handling for ImagePath, and minor documentation fixes |
| README.md | Updated commit hash and API specification to stable version |
Comments suppressed due to low confidence (1)
src/StackHCIVM/StackHCIVM.Autorest/custom/New-AzStackHCIVMImage.ps1
Outdated
Show resolved
Hide resolved
|
/azp run |
|
Commenter does not have sufficient privileges for PR 28237 in repo Azure/azure-powershell |
hvedati
changed the title
|
/azp run |
|
Commenter does not have sufficient privileges for PR 28237 in repo Azure/azure-powershell |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
Hi @hvedati, the ChangeLog file path is src/StackHCIVM/StackHCIVM/ChangeLog.md. Please add a line right below Upcoming Release using the past tense to describe the purpose of this PR. Thanks. Please check the placeholders:
After you run |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
src/StackHCIVM/StackHCIVM.Autorest/examples/Get-AzStackHCIVMAttestationStatuses.md
Outdated
Show resolved
Hide resolved
|
Hi @hvedati, please notice the next code complete date is 07/29/2025. If the PR can't be ready by then, it'll be left over to the next next release. |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Co-authored-by: Yan Xu <[email protected]>
…e.ps1 Co-authored-by: Copilot <[email protected]>
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
src/StackHCIVM/StackHCIVM.Autorest/examples/Get-AzStackHCIVMAttestationStatuses.md
Outdated
Show resolved
Hide resolved
|
Please fix CI errors. |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
@NoriZC I have gone through the breaking changes and there are two types of breaking changes present. The number corresponds to the row in the BreakingChanges.csv which is added to the PR. 12, 13, 21, 22, 53, 54, - The cmdlet 'Update-AzStackHCIVMLogicalNetwork' no longer has output type 'Microsoft.Azure.PowerShell.Cmdlets.StackHCIVM.Models.ILogicalNetworks'. and The cmdlet 'Update-AzStackHCIVMImage' no longer has output type 'Microsoft.Azure.PowerShell.Cmdlets.StackHCIVM.Models.IGalleryImages'. This is due to an update in the swagger from the old model to typespec. This change makes sense and was a result of the autogeneration pointing at the new swagger. Since this powershell module is not used by customer it should be safe to update this type. Both of these types of breaking changes are needed in our module. It should be safe to include these breaking changes since this module is not used by customers. What is the process for adding these breaking changes? |
|
Hi @hvedati |
|
|
|
Hi @hvedati the securestring breaking changes make sense but can you elaborate on "Since this powershell module is not used by customer it should be safe to update this type."? If not by cusomters, who would use it and what would the impact of the breaking change be to them? |
isra-fel
added
needs-revision
Contains Breaking Change
|
This PR was labeled "needs-revision" because it has unresolved review comments or CI failures. |
|
To the author of the pull request, |
|
Kindly ping @hvedati |
|
Closing the PR for lack of activity. Feel free to reopen to continue working on it. Thanks 😀 |
5 participants
Description
Mandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.mdand reviewed the following information:ChangeLog.mdfile(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.## Upcoming Releaseheader in the past tense.ChangeLog.mdif no new release is required, such as fixing test case only.