Skip to content

[PS] Migrate StreamAnalytics module to autorest v4 #28316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

JoyerJin
Copy link
Contributor

@JoyerJin JoyerJin commented Aug 1, 2025

Description

Mandatory Checklist

  • SHOULD update ChangeLog.md file(s) appropriately
    • Update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
      • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT adjust version of module manually in pull request

Copy link

Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status.

@JoyerJin JoyerJin added the Breaking Change Release This PR contains breaking change label Aug 1, 2025
Copy link

github-actions bot commented Aug 1, 2025

To the author of the pull request,
This PR was labeled "Breaking Change Release" because it contains breaking changes.

  • According to our policy, breaking changes can only take place during major release and they must be preannounced.
  • Please follow our guide on the detailed steps.
  • Required: Please fill in the task below to facilitate our contact,you will receive notifications related to breaking changes.

@JoyerJin JoyerJin marked this pull request as ready for review August 5, 2025 09:18
@Copilot Copilot AI review requested due to automatic review settings August 5, 2025 09:18
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR migrates the StreamAnalytics module to AutoRest v4, upgrading the code generator to introduce various new features. The migration updates model type references, parameter types, and adds new parameter sets for JSON file/string inputs.

Key changes include:

  • Model namespace updates from API-specific to generic model types
  • Parameter type changes from strongly-typed enums to string types
  • Addition of new parameter sets supporting JSON file and string inputs

Reviewed Changes

Copilot reviewed 98 out of 99 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
tools/StaticAnalysis/Exceptions/Az.StreamAnalytics/BreakingChangeIssues.csv Documents breaking changes from the v4 migration including type changes and parameter modifications
src/StreamAnalytics/StreamAnalytics/help/*.md Updates help documentation to reflect new model types and parameter sets
src/StreamAnalytics/StreamAnalytics.Autorest/test/*.ps1 Fixes file path separators in test files from backslashes to forward slashes
src/StreamAnalytics/StreamAnalytics.Autorest/custom/*.ps1 Updates custom cmdlets to use new model type references
src/StreamAnalytics/StreamAnalytics.Autorest/examples/*.md Corrects filename typos from "StroageAccount.json" to "StorageAccount.json"

@@ -111,10 +111,10 @@ function setupEnv() {
$iothubKey = $resourceKey.PrimaryKey

# Update value of the template json.
$storageAccountParam = Get-Content .\test\template-json\StroageAccount.json | ConvertFrom-Json
$storageAccountParam = Get-Content .\test\template-json\StorageAccount.json | ConvertFrom-Json
Copy link
Preview

Copilot AI Aug 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The filename 'StorageAccount.json' was corrected from the misspelled 'StroageAccount.json', but this correction needs to be consistently applied throughout the codebase.

Copilot uses AI. Check for mistakes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Breaking Change Release This PR contains breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant