Add MemorySizeInGB parameter for SQL Managed Instance CRUD #28341
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status. |
UrosKrsticMIPerf
changed the title
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for flexible memory configuration to Azure SQL Managed Instance by introducing a new MemorySizeInGb parameter. The changes enable users to specify custom memory sizes when creating or updating managed instances through PowerShell cmdlets.
Key Changes
- Added
MemorySizeInGbproperty to the managed instance model and cmdlets - Updated the adapter to handle the new memory size parameter in API calls
- Added comprehensive test coverage for the flexible memory functionality
Reviewed Changes
Copilot reviewed 11 out of 30 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| src/Sql/Sql/ManagedInstance/Services/AzureSqlManagedInstanceAdapter.cs | Added memory size mapping between model and API requests/responses |
| src/Sql/Sql/ManagedInstance/Model/AzureSqlManagedInstanceModel.cs | Added MemorySizeInGb property to the managed instance model |
| src/Sql/Sql/ManagedInstance/Cmdlet/SetAzureSqlManagedInstance.cs | Added MemorySizeInGb parameter to Set-AzSqlManagedInstance cmdlet |
| src/Sql/Sql/ManagedInstance/Cmdlet/NewAzureSqlManagedInstance.cs | Added MemorySizeInGb parameter to New-AzSqlManagedInstance cmdlet |
| src/Sql/Sql/ChangeLog.md | Added placeholder entry for the flexible memory feature |
| src/Sql/Sql.Test/SessionRecords/Microsoft.Azure.Commands.Sql.Test.ScenarioTests.ManagedInstanceCrudScenarioTests/TestCreateManagedInstanceFlexibleMemory.json | Added test session recording for flexible memory testing |
| src/Sql/Sql.Test/ScenarioTests/ManagedInstanceCrudScenarioTests.ps1 | Added PowerShell test functions for flexible memory scenarios |
| src/Sql/Sql.Test/ScenarioTests/ManagedInstanceCrudScenarioTests.cs | Added C# test methods for flexible memory functionality |
| src/Sql/Sql.Test/ScenarioTests/Common.ps1 | Added helper function for flexible memory test parameters |
| src/Sql/Sql.Management.Sdk/README.md | Updated API specification version to support flexible memory |
| build.sln | Added solution file for build configuration |
| @@ -93,6 +93,11 @@ public class AzureSqlManagedInstanceModel | |||
| /// </summary> | |||
| public int? VCores { get; set; } | |||
|
|
|||
| /// <summary> | |||
| /// Gets or sets the number of VCores. | |||
There was a problem hiding this comment.
The documentation comment is incorrect. This property represents memory size in GB, not the number of VCores. It should be '/// Gets or sets the memory size in GB.'
Suggested change
| /// Gets or sets the number of VCores. | |
| /// Gets or sets the memory size in GB. |
Copilot uses AI. Check for mistakes.
src/Sql/Sql/ManagedInstance/Cmdlet/SetAzureSqlManagedInstance.cs
Outdated
Show resolved
Hide resolved
src/Sql/Sql/ManagedInstance/Cmdlet/SetAzureSqlManagedInstance.cs
Outdated
Show resolved
Hide resolved
src/Sql/Sql/ManagedInstance/Cmdlet/NewAzureSqlManagedInstance.cs
Outdated
Show resolved
Hide resolved
src/Sql/Sql/ManagedInstance/Cmdlet/NewAzureSqlManagedInstance.cs
Outdated
Show resolved
Hide resolved
src/Sql/Sql/ManagedInstance/Cmdlet/NewAzureSqlManagedInstance.cs
Outdated
Show resolved
Hide resolved
src/Sql/Sql/ChangeLog.md
Outdated
| @@ -18,6 +18,7 @@ | |||
| - Additional information about change #1 | |||
| --> | |||
| ## Upcoming Release | |||
| placeholder to sql mi flexible memory feature | |||
There was a problem hiding this comment.
The changelog entry should be more descriptive and follow proper formatting. It should describe what was added in past tense, such as '* Added MemorySizeInGb parameter to New-AzSqlManagedInstance and Set-AzSqlManagedInstance cmdlets for flexible memory configuration'.
Suggested change
| placeholder to sql mi flexible memory feature | |
| * Added `MemorySizeInGb` parameter to `New-AzSqlManagedInstance` and `Set-AzSqlManagedInstance` cmdlets for flexible memory configuration. |
Copilot uses AI. Check for mistakes.
…ught when an instance doesn't exist and update comments regarding the MemorySizeInGB parameter. Update tests that are failing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Mandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.mdand reviewed the following information:ChangeLog.mdfile(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.## Upcoming Releaseheader in the past tense.ChangeLog.mdif no new release is required, such as fixing test case only.