Az.StorageSync | Added TenantId of ARC Server and checked with StorageSyncService tenant to prevent unsupported configuration

[ankushbindlish2]

Description

Mandatory Checklist

• Please choose the target release of Azure PowerShell. (⚠️Target release is a different concept from API readiness. Please click below links for details.)

  • General release
  • Public preview
  • Private preview
  • Engineering build
  • No need for a release

• Check this box to confirm: I have read the Submitting Changes section of CONTRIBUTING.md and reviewed the following information:

• SHOULD update ChangeLog.md file(s) appropriately
  • Update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
  • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
• SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
• SHOULD have proper test coverage for changes in pull request.
• SHOULD NOT adjust version of module manually in pull request

[azure-client-tools-bot-prd]

Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status.

[Copilot]

Pull Request Overview

This PR enhances the Azure Storage Sync server registration functionality to validate tenant alignment between ARC servers and Storage Sync Services, preventing unsupported cross-tenant configurations.

• Extracts tenant ID from server managed identity tokens and compares with Storage Sync Service tenant
• Refactors server application identity handling to return both application ID and tenant ID asynchronously
• Adds validation to prevent cross-tenant server registrations with appropriate error messaging

Reviewed Changes

Copilot reviewed 13 out of 16 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
SetRegisteredServerCommand.cs	Updated to use new async method for getting server application identity
RegisterServerCommand.cs	Added tenant ID validation and passes tenant to registration client
StorageSyncResources.resx	Added error message resource for missing Azure context tenant ID
ServerManagedIdentityTokenHelper.cs	Added method to extract tenant ID from tokens and updated documentation
ServerManagedIdentityProvider.cs	Refactored to return ServerApplicationIdentity with both app ID and tenant ID
ServerApplicationIdentity.cs	New class to encapsulate server application identity information
ISyncServerRegistration.cs	Updated interface to accept tenant ID parameter
IServerManagedIdentityProvider.cs	Updated interface for async operation returning ServerApplicationIdentity
SyncServerRegistrationClientBase.cs	Added tenant validation logic in registration process
SyncServerRegistrationClient.cs	Updated to use new async identity retrieval method
MockSyncServerRegistrationClientBase.cs	Updated mock implementation for new interface
MockSyncServerRegistrationClient.cs	Updated mock to return ServerApplicationIdentity objects
MockServerManagedIdentityProvider.cs	Updated mock provider for new async interface

Files not reviewed (1)

• src/StorageSync/StorageSync/Properties/StorageSyncResources.Designer.cs: Language not supported

[NoriZC]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 3 pipeline(s).

[github-actions]

This PR was labeled "needs-revision" because it has unresolved review comments or CI failures.
Please resolve all open review comments and make sure all CI checks are green. Refer to our guide to troubleshoot common CI failures.